Bug 251400 - make find-lang.sh --with-gnome pick up omf files
Summary: make find-lang.sh --with-gnome pick up omf files
Alias: None
Product: Fedora
Classification: Fedora
Component: rpm
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Panu Matilainen
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2007-08-08 18:44 UTC by Matthias Clasen
Modified: 2007-11-30 22:12 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2007-08-15 09:51:01 UTC
Type: ---

Attachments (Terms of Use)
patch (573 bytes, patch)
2007-08-08 18:44 UTC, Matthias Clasen
no flags Details | Diff

Description Matthias Clasen 2007-08-08 18:44:38 UTC
I've started using find-lang --with-gnome in spec files now, in the hope of
using _install_langs to reduce the size of live cds. It would be nice if
--with-gnome would not only pick up the help files in /usr/share/gnome/help,
but also the omf files in /usr/share/omf that go with them. 

The patch does just that. If you are worried about compatibility, we could
also make that depend on a new --with-omf option, but I don't really think
that is necessary.

Comment 1 Matthias Clasen 2007-08-08 18:44:38 UTC
Created attachment 160927 [details]

Comment 2 Matthias Clasen 2007-08-08 19:46:41 UTC
Jeremy also proposes to make --with-gnome --with-kde the default in our %find_lang 

Comment 3 Panu Matilainen 2007-08-10 12:02:37 UTC
I suppose it'd be good to have --with-omf to be in line with the other cases
but... I wonder what has been the real point of all the --with-gnome etc options
in the first place.

Comment 4 Matthias Clasen 2007-08-10 13:29:43 UTC
The point is to get %lang tagging for all the big locale-dependent files, so that
_install_langs can do its magic. The documentation under gnome/help is the reason
why evolution is the second-largest package on the live cd...

Comment 5 Panu Matilainen 2007-08-10 13:40:10 UTC
Yes, I can see that :) I'm just wondering why those --gnome etc things have bee
optional to begin with if they dont break anything.

To make it clear, I'm not opposed to this or anything, just curious.

Comment 6 Matthias Clasen 2007-08-10 13:51:54 UTC
Good question. 

The only slight concern is that turning it on by default now will cause
duplication between foo.lang and the explicit file list, with one entry
having a %lang tag, the other not. But I assume that rpm will handle that

Comment 7 Panu Matilainen 2007-08-15 09:51:01 UTC
Hey, this is rpm - assumptions are inherently dangerous :) I don't actually know
what will happen in such a case, but the worst that can happen is that
duplicates (which you'll get warned about) dont get treated as lang-files. Which
is harmless as it's no worse than what was before.

As for the patch itself, upstream at rpm.org and building right now into
rawhide, will be in rpm- I've been totally blind and missed the
fact that the .omf files were only searched when --with-gnome was specified,
that's safe enough for me. Thanks for the patch :)

Turning --with-kde and --with-gnome on by default in redhat-rpm-config is out of
my control, but I'm in no way opposed to that.

Note You need to log in before you can comment on or make changes to this bug.