Bug 2519524
| Summary: | Review Request: perl-Audio-Scan - Fast C metadata and tag reader for all common audio file formats | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Oliver <mavit> |
| Component: | Package Review | Assignee: | MartinKG <mgansser> |
| Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mgansser, package-review |
| Target Milestone: | --- | Flags: | mgansser:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://metacpan.org/dist/Audio-Scan | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peter Oliver
2026-08-19 12:35:57 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/10882565 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2519524-perl-audio-scan/fedora-rawhide-x86_64/10882565-perl-Audio-Scan/fedora-review/review.txt Found issues: - Explicit dependency on perl-devel is not allowed unless building architecture-specific code which links to libperl.so Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. quick review: I think the license type should be changed to: License: GPL-2.0-or-later AND GPL-2.0-only AND BSD-3-Clause AND MIT AND Zlib and the license brakedown should be added like this: # main code is GPL-2.0-or-later: # include/aac.h # include/asf.h # include/common.h # include/dsdiff.h # include/dsf.h # include/flac.h # include/id3.h # include/mp3.h # include/mp4.h # include/ogf.h # include/ogg.h # include/opus.h # include/wav.h # include/wavpack.h # src/aac.c # src/asf.c # src/common.c # src/dsdiff.c # src/dsf.c # src/flac.c # src/id3.c # src/id3_compat.c # src/id3_compat.gperf # src/mp3.c # src/mp4.c # src/ogf.c # src/ogg.c # src/opus.c # src/wav.c # src/wavpack.c # # GPL-2.0-only: # META.json # COPYING # # BSD-3-Clause: # include/mpc.h # include/pstdint.h # src/mpc.c # # MIT: # include/ape.h # src/ape.c # # Zlib: # include/md5.h # src/md5.c and you should add # Bundled libraries: Provides: bundled(musepack) because Musepack is included in the following files: # BSD-3-Clause: # perl-Audio-Scan-1.13-build/Audio-Scan-1.13/include/mpc.h # perl-Audio-Scan-1.13-build/Audio-Scan-1.13/include/pstdint.h # perl-Audio-Scan-1.13-build/Audio-Scan-1.13/src/mpc.c |