Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://mavit.fedorapeople.org/rpms/perl-Audio-Scan.spec SRPM URL: https://mavit.fedorapeople.org/rpms/perl-Audio-Scan-1.13-1.fc44.src.rpm Description: Fast C metadata and tag reader for all common audio file formats Fedora Account System Username: mavit
Copr build: https://copr.fedorainfracloud.org/coprs/build/10882565 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2519524-perl-audio-scan/fedora-rawhide-x86_64/10882565-perl-Audio-Scan/fedora-review/review.txt Found issues: - Explicit dependency on perl-devel is not allowed unless building architecture-specific code which links to libperl.so Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
quick review: I think the license type should be changed to: License: GPL-2.0-or-later AND GPL-2.0-only AND BSD-3-Clause AND MIT AND Zlib and the license brakedown should be added like this: # main code is GPL-2.0-or-later: # include/aac.h # include/asf.h # include/common.h # include/dsdiff.h # include/dsf.h # include/flac.h # include/id3.h # include/mp3.h # include/mp4.h # include/ogf.h # include/ogg.h # include/opus.h # include/wav.h # include/wavpack.h # src/aac.c # src/asf.c # src/common.c # src/dsdiff.c # src/dsf.c # src/flac.c # src/id3.c # src/id3_compat.c # src/id3_compat.gperf # src/mp3.c # src/mp4.c # src/ogf.c # src/ogg.c # src/opus.c # src/wav.c # src/wavpack.c # # GPL-2.0-only: # META.json # COPYING # # BSD-3-Clause: # include/mpc.h # include/pstdint.h # src/mpc.c # # MIT: # include/ape.h # src/ape.c # # Zlib: # include/md5.h # src/md5.c and you should add # Bundled libraries: Provides: bundled(musepack) because Musepack is included in the following files: # BSD-3-Clause: # perl-Audio-Scan-1.13-build/Audio-Scan-1.13/include/mpc.h # perl-Audio-Scan-1.13-build/Audio-Scan-1.13/include/pstdint.h # perl-Audio-Scan-1.13-build/Audio-Scan-1.13/src/mpc.c
Thanks for the review. Both issues addressed. SRPM URL: https://mavit.fedorapeople.org/rpms/perl-Audio-Scan-1.13-3.fc46.src.rpm
In my opinion, that's okay. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "MIT License", "BSD 3-Clause License", "*No copyright* GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "*No copyright* GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "zlib License", "GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "*No copyright* Public domain". 250 files have unknown license. Detailed output of licensecheck in /home/martin/rpmbuild/SPECS/perl-Audio-Scan/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [-]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/perl5/vendor_perl/auto/Audio/Scan [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/perl5/vendor_perl/auto/Audio/Scan [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [-]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 44480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [-]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: perl-Audio-Scan-1.13-3.fc46.x86_64.rpm perl-Audio-Scan-1.13-3.fc46.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfm7h31gv')] checks: 32, packages: 2 perl-Audio-Scan.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Audio-Scan/COPYING 2 packages and 0 specfiles checked; 1 errors, 0 warnings, 8 filtered, 1 badness; has taken 0.4 s Rpmlint (debuginfo) ------------------- Checking: perl-Audio-Scan-debuginfo-1.13-3.fc46.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpetxsgh2x')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.10.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 33, packages: 2 perl-Audio-Scan.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Audio-Scan/COPYING 2 packages and 0 specfiles checked; 1 errors, 0 warnings, 9 filtered, 1 badness; has taken 0.3 s Unversioned so-files -------------------- perl-Audio-Scan: /usr/lib64/perl5/vendor_perl/auto/Audio/Scan/Scan.so Source checksums ---------------- https://cpan.metacpan.org/authors/id/E/EL/ELBRUS/Audio-Scan-1.13.tar.gz : CHECKSUM(SHA256) this package : f8c28c63af5615ec56a125be0e846ee82928d3f7ac622fc479253dcd8108769e CHECKSUM(SHA256) upstream package : f8c28c63af5615ec56a125be0e846ee82928d3f7ac622fc479253dcd8108769e Requires -------- perl-Audio-Scan (rpmlib, GLIBC filtered): libc.so.6()(64bit) libperl.so.5.44()(64bit) libz.so.1()(64bit) perl(:MODULE_COMPAT_5.44.0) perl(XSLoader) perl(constant) perl(strict) perl-libs rtld(GNU_HASH) Provides -------- perl-Audio-Scan: bundled(libmpcdec) perl(Audio::Scan) perl-Audio-Scan perl-Audio-Scan(x86-64) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -rn ../SRPMS/perl-Audio-Scan-1.13-3.fc44.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api, Perl Disabled plugins: R, Ocaml, PHP, Haskell, Python, Java, fonts, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Audio-Scan Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`