Bug 2519524 - Review Request: perl-Audio-Scan - Fast C metadata and tag reader for all common audio file formats
Summary: Review Request: perl-Audio-Scan - Fast C metadata and tag reader for all comm...
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: MartinKG
QA Contact: Fedora Extras Quality Assurance
URL: https://metacpan.org/dist/Audio-Scan
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-08-19 12:35 UTC by Peter Oliver
Modified: 2026-08-26 14:59 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
mgansser: fedora-review?


Attachments (Terms of Use)

Description Peter Oliver 2026-08-19 12:35:57 UTC
Spec URL: https://mavit.fedorapeople.org/rpms/perl-Audio-Scan.spec
SRPM URL: https://mavit.fedorapeople.org/rpms/perl-Audio-Scan-1.13-1.fc44.src.rpm
Description: Fast C metadata and tag reader for all common audio file formats
Fedora Account System Username: mavit

Comment 1 Fedora Review Service 2026-08-20 01:56:57 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10882565
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2519524-perl-audio-scan/fedora-rawhide-x86_64/10882565-perl-Audio-Scan/fedora-review/review.txt

Found issues:

- Explicit dependency on perl-devel is not allowed unless building architecture-specific code which links to libperl.so
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 MartinKG 2026-08-26 14:55:54 UTC
quick review:

I think the license type should be changed to:

License:        GPL-2.0-or-later AND GPL-2.0-only AND BSD-3-Clause AND MIT AND Zlib

and the license brakedown should be added like this:

# main code is GPL-2.0-or-later:
# include/aac.h
# include/asf.h
# include/common.h
# include/dsdiff.h
# include/dsf.h
# include/flac.h
# include/id3.h
# include/mp3.h
# include/mp4.h
# include/ogf.h
# include/ogg.h
# include/opus.h
# include/wav.h
# include/wavpack.h
# src/aac.c
# src/asf.c
# src/common.c
# src/dsdiff.c
# src/dsf.c
# src/flac.c
# src/id3.c
# src/id3_compat.c
# src/id3_compat.gperf
# src/mp3.c
# src/mp4.c
# src/ogf.c
# src/ogg.c
# src/opus.c
# src/wav.c
# src/wavpack.c
#

# GPL-2.0-only:
# META.json
# COPYING
#

# BSD-3-Clause:
# include/mpc.h
# include/pstdint.h
# src/mpc.c
#

# MIT:
# include/ape.h
# src/ape.c
#

# Zlib:
# include/md5.h
# src/md5.c

and you should add

# Bundled libraries:
Provides:       bundled(musepack)

because Musepack is included in the following files:

# BSD-3-Clause:
# perl-Audio-Scan-1.13-build/Audio-Scan-1.13/include/mpc.h
# perl-Audio-Scan-1.13-build/Audio-Scan-1.13/include/pstdint.h
# perl-Audio-Scan-1.13-build/Audio-Scan-1.13/src/mpc.c


Note You need to log in before you can comment on or make changes to this bug.