Bug 2526571
| Summary: | Review Request: Dragon GL: The Long Descent into the Dragon's Maw, 3D multi-user client-server dungeon exploration simulator. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicola Taibi <nicola.taibi.1967> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| URL: | https://github.com/nicolataibi/dragongl | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 177841, 1364745 | ||
|
Description
Nicola Taibi
2026-08-31 22:08:40 UTC
Posting updated package URLs to trigger the automated review tool (Fedora Review Service): Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/dragon-gl/fedora-45-x86_64/10968795-dragongl/dragongl.spec SRPM URL: https://packages.redhat.com/api/pulp-content/public-copr/ntaibi/dragon-gl/fedora-45-x86_64/Packages/d/dragongl-2026.09.10.01-1.fc45.src.rpm Posting updated package URLs to trigger the automated review tool (Fedora Review Service): Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/dragon-gl/fedora-rawhide-x86_64/10974841-dragongl/dragongl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ntaibi/dragon-gl/srpm-builds/10974841/dragongl-2026.09.11.01-1.src.rpm [fedora-review-service-build] Posting updated package URLs to trigger the automated review tool (Fedora Review Service): Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/dragon-gl/srpm-builds/10995425/dragongl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ntaibi/dragon-gl/srpm-builds/10995425/dragongl-2026.09.17.01-1.src.rpm [fedora-review-service-build] > Source0: %{url}/archive/refs/tags/%{version}.tar.gz#/%{name}-%{version}.tar.gz You can avoid the hash trick by using "%{URL}/archive/refs/tags/%{version}/%{name}-%{version}.tar.gz" here. > %prep > %autosetup -n %{name}-%{version} -p1 > > > %cmake 1. You can drop the -n argument to &autosetup, as %{name}-%{version} is the default value. 2. The %cmake call should be placed in %build, or %conf. > %files data > %dir %{_datadir}/%{name} > %{_datadir}/%{name}/shaders/ > %dir %{_datadir}/%{name}/data > %{_datadir}/%{name}/data/*.json > > %files tools > %{_datadir}/%{name}/tools/analyze_balance.py > %{_datadir}/%{name}/tools/generate_pdf_map.py > [...] You can simplify things by doing this instead: > %files data > %{_datadir}/%{name} > %exclude %{_datadir}/%{name}/tools > > %files tools > %dir %{_datadir}/%{name} > %{_datadir}/%{name}/tools This will make -data include all the files inside %{_datadir}/%{name}/, with the exception of the tools/ sub-directory and its contents. The tools package will properly own the tools/ sub-directory and all the files inside. The "%dir %{_datadir}/%{name}" bit on -tools is needed as it can be installed independently of -data, so it also needs to own this directory. Also - the main package requires -data, but other than that, packages can be installed independently. However, only the main package ships the license text. It is required that the license text is always present, regardless of which combination of packages the user installs. Thanks for the review. I have applied all the suggested changes: * simplified `Source0` to use the tag directory directly; * removed the redundant `-n` argument from `%autosetup`; * moved `%cmake` from `%prep` to `%build`; * simplified the `data` and `tools` `%files` sections using `%exclude`; * added `%license LICENSE.txt` to all subpackages so the license is always present. The updated package builds successfully. CMake reports some unused manually specified variables, but these are only configuration warnings and do not affect the build. With kind regards, Nick Posting updated package URLs to trigger the automated review tool (Fedora Review Service): Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/dragon-gl/srpm-builds/11030684/dragongl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ntaibi/dragon-gl/srpm-builds/11030684/dragongl-2026.09.24.01-1.src.rpm [fedora-review-service-build] |