Fedora Account System
Red Hat Associate
Red Hat Customer
Dear Bugzilla Team, Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/dragon-gl/srpm-builds/10968795/dragongl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ntaibi/dragon-gl/srpm-builds/10968795/dragongl-2026.09.10.01-1.src.rpm Description: Dragon GL: The Long Descent into the Dragon's Maw is a high-performance, 3D multi-user client-server dungeon exploration simulator. The engine features a fully functional, original fantasy RPG mechanical core and real-time front-ends built natively on both OpenGL (via GLFW) and Vulkan. The game builds successfully in Copr for Fedora Rawhide and Fedora 44 and x86_64/i386. Notes: This is my second package submission. My previous package submission (space-gl) successfully received an LGTM review https://bugzilla.redhat.com/show_bug.cgi?id=2437502. I am currently looking for a reviewer and a sponsor for this new package. Note on Intellectual Property: While the game captures the spirit of classic dungeon-crawlers, it features entirely custom game mechanics distinct from traditional tabletop RPG systems (such as Dungeons & Dragons). The project uses no proprietary assets or copyright-restricted material, ensuring full compliance with Fedora's licensing requirements. Copr Project: https://copr.fedorainfracloud.org/coprs/ntaibi/dragon-gl/ I am awaiting your approval or any further feedback before proceeding. With kind regards, Nick Reproducible: Always
Posting updated package URLs to trigger the automated review tool (Fedora Review Service): Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/dragon-gl/fedora-45-x86_64/10968795-dragongl/dragongl.spec SRPM URL: https://packages.redhat.com/api/pulp-content/public-copr/ntaibi/dragon-gl/fedora-45-x86_64/Packages/d/dragongl-2026.09.10.01-1.fc45.src.rpm
Posting updated package URLs to trigger the automated review tool (Fedora Review Service): Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/dragon-gl/fedora-rawhide-x86_64/10974841-dragongl/dragongl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ntaibi/dragon-gl/srpm-builds/10974841/dragongl-2026.09.11.01-1.src.rpm [fedora-review-service-build]
Posting updated package URLs to trigger the automated review tool (Fedora Review Service): Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/dragon-gl/srpm-builds/10995425/dragongl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ntaibi/dragon-gl/srpm-builds/10995425/dragongl-2026.09.17.01-1.src.rpm [fedora-review-service-build]
> Source0: %{url}/archive/refs/tags/%{version}.tar.gz#/%{name}-%{version}.tar.gz You can avoid the hash trick by using "%{URL}/archive/refs/tags/%{version}/%{name}-%{version}.tar.gz" here. > %prep > %autosetup -n %{name}-%{version} -p1 > > > %cmake 1. You can drop the -n argument to &autosetup, as %{name}-%{version} is the default value. 2. The %cmake call should be placed in %build, or %conf. > %files data > %dir %{_datadir}/%{name} > %{_datadir}/%{name}/shaders/ > %dir %{_datadir}/%{name}/data > %{_datadir}/%{name}/data/*.json > > %files tools > %{_datadir}/%{name}/tools/analyze_balance.py > %{_datadir}/%{name}/tools/generate_pdf_map.py > [...] You can simplify things by doing this instead: > %files data > %{_datadir}/%{name} > %exclude %{_datadir}/%{name}/tools > > %files tools > %dir %{_datadir}/%{name} > %{_datadir}/%{name}/tools This will make -data include all the files inside %{_datadir}/%{name}/, with the exception of the tools/ sub-directory and its contents. The tools package will properly own the tools/ sub-directory and all the files inside. The "%dir %{_datadir}/%{name}" bit on -tools is needed as it can be installed independently of -data, so it also needs to own this directory. Also - the main package requires -data, but other than that, packages can be installed independently. However, only the main package ships the license text. It is required that the license text is always present, regardless of which combination of packages the user installs.
Thanks for the review. I have applied all the suggested changes: * simplified `Source0` to use the tag directory directly; * removed the redundant `-n` argument from `%autosetup`; * moved `%cmake` from `%prep` to `%build`; * simplified the `data` and `tools` `%files` sections using `%exclude`; * added `%license LICENSE.txt` to all subpackages so the license is always present. The updated package builds successfully. CMake reports some unused manually specified variables, but these are only configuration warnings and do not affect the build. With kind regards, Nick Posting updated package URLs to trigger the automated review tool (Fedora Review Service): Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/dragon-gl/srpm-builds/11030684/dragongl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ntaibi/dragon-gl/srpm-builds/11030684/dragongl-2026.09.24.01-1.src.rpm [fedora-review-service-build]