Bug 2530525

Summary: Review Request: ghc-toml-reader - TOML format parser compliant with v1.0.0
Product: [Fedora] Fedora Reporter: Jens Petersen <petersen>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://hackage.haskell.org/package/toml-reader
Whiteboard:
Fixed In Version: ghc-toml-reader-0.3.0.0-1.fc46 Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2026-10-08 22:50:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2511001    

Description Jens Petersen 2026-09-09 06:24:33 UTC
Spec URL: https://petersen.fedorapeople.org/reviews/ghc-toml-reader/ghc-toml-reader.spec
SRPM URL: https://petersen.fedorapeople.org/reviews/ghc-toml-reader/ghc-toml-reader-0.3.0.0-1.fc46.src.rpm

Description:
TOML format parser compliant with v1.0.0. See README.md for more details.

Fedora Account System Username: petersen


Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=150048418

Comment 1 Michel Lind 2026-09-22 15:31:46 UTC
LGTM

===

Package was generated with cabal-rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (please consider packaging skeletest and enabling tests)
✅ latest version of the package is packaged (spec & Hackage: 0.3.0.0)
✅ license matches upstream specification and is acceptable for Fedora (spec: BSD-3-Clause; .cabal: BSD3 (equivalent))
✅ license file is included with %license in %files
✅ package complies with Haskell Packaging Guidelines

Package APPROVED.

===

Recommended post-import haskell-sig tasks:

- set up package on release-monitoring.org:
  project: toml-reader
  homepage: https://hackage.haskell.org/package/toml-reader
  backend: Hackage
  version scheme: semantic
  distro: Fedora
  Package: ghc-toml-reader

- add @haskell-lang-sig with "commit" access as package co-maintainer

- track package in koschei for all built branches

Comment 2 Fedora Admin user for bugzilla script actions 2026-09-29 13:06:53 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-toml-reader
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 3 Jens Petersen 2026-09-29 13:06:59 UTC
Thank you for the review, Michel!

Comment 4 Jens Petersen 2026-09-29 13:12:54 UTC
(In reply to Michel Lind from comment #1)
> 🫤 test suite is run and all unit tests pass (please consider packaging
> skeletest and enabling tests)

Okay will put it on my list and look into it.

> Recommended post-import haskell-sig tasks:
> 
> - set up package on release-monitoring.org:
>   project: toml-reader
>   homepage: https://hackage.haskell.org/package/toml-reader
>   backend: Hackage
>   version scheme: semantic
>   distro: Fedora
>   Package: ghc-toml-reader
> 
> - add @haskell-lang-sig with "commit" access as package co-maintainer
> 
> - track package in koschei for all built branches

I like this template :up:

Comment 6 Fedora Update System 2026-10-07 16:31:37 UTC
FEDORA-2026-ad082bb407 (encapsule-0.5.1-2.fc45, ghc-shell-monad-0.6.10-3.fc45, and 1 more) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-ad082bb407

Comment 7 Fedora Update System 2026-10-08 02:09:13 UTC
FEDORA-2026-ad082bb407 has been pushed to the Fedora 45 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-ad082bb407 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-ad082bb407

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2026-10-08 05:15:00 UTC
FEDORA-2026-f359a075cd (encapsule-0.5.1-2.fc44, ghc-shell-monad-0.6.10-3.fc44, and 1 more) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-f359a075cd

Comment 10 Fedora Update System 2026-10-08 05:50:43 UTC
FEDORA-2026-df412db030 (encapsule-0.5.1-2.fc43, ghc-shell-monad-0.6.10-3.fc43, and 1 more) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-df412db030

Comment 12 Fedora Update System 2026-10-08 14:05:12 UTC
FEDORA-EPEL-2026-04594c4962 (encapsule-0.5.1-2.el10_4, ghc-shell-monad-0.6.10-3.el10_4, and 1 more) has been submitted as an update to Fedora EPEL 10.4.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-04594c4962

Comment 13 Fedora Update System 2026-10-08 22:50:42 UTC
FEDORA-2026-ad082bb407 (encapsule-0.5.1-2.fc45, ghc-shell-monad-0.6.10-3.fc45, and 1 more) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2026-10-09 02:29:55 UTC
FEDORA-2026-f359a075cd has been pushed to the Fedora 44 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-f359a075cd \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-f359a075cd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2026-10-09 02:32:53 UTC
FEDORA-EPEL-2026-04594c4962 has been pushed to the Fedora EPEL 10.4 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-04594c4962

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2026-10-09 02:55:08 UTC
FEDORA-2026-df412db030 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-df412db030 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-df412db030

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2026-10-17 01:04:19 UTC
FEDORA-2026-f359a075cd (encapsule-0.5.1-2.fc44, ghc-shell-monad-0.6.10-3.fc44, and 1 more) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2026-10-17 01:21:18 UTC
FEDORA-EPEL-2026-04594c4962 (encapsule-0.5.1-2.el10_4, ghc-shell-monad-0.6.10-3.el10_4, and 1 more) has been pushed to the Fedora EPEL 10.4 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2026-10-17 01:32:19 UTC
FEDORA-2026-df412db030 (encapsule-0.5.1-2.fc43, ghc-shell-monad-0.6.10-3.fc43, and 1 more) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.