Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://petersen.fedorapeople.org/reviews/encapsule/encapsule.spec SRPM URL: https://petersen.fedorapeople.org/reviews/encapsule/encapsule-0.4-1.fc45.src.rpm Description: This tool (originally based on the toolbox-constrained project) allows running isolated toolbox containers with podman. Mounting of home and host integration are not enabled by default, but one can choose options to do so including capabilities specified in a toml configuration file. Fedora Account System Username: petersen Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=148698082
This is intended for https://fedoraproject.org/wiki/Changes/Encapsule_devel_containers
Copr build: https://copr.fedorainfracloud.org/coprs/build/10811640 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2511001-encapsule/fedora-rawhide-x86_64/10811640-encapsule/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Builds are available for fedora releases and epel10 in https://copr.fedorainfracloud.org/coprs/petersen/encapsule/
Spec URL: https://petersen.fedorapeople.org/reviews/encapsule/encapsule.spec SRPM URL: https://petersen.fedorapeople.org/reviews/encapsule/encapsule-0.4.1-1.fc45.src.rpm - https://hackage.haskell.org/package/encapsule-0.4.1/changelog
Created attachment 2154109 [details] The .spec file difference from Copr build 10811640 to 10841749
Copr build: https://copr.fedorainfracloud.org/coprs/build/10841749 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2511001-encapsule/fedora-rawhide-x86_64/10841749-encapsule/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this review.
> Source1: https://hackage.haskell.org/package/%{shellmonad}/%{shellmonad}.tar.gz > Source2: https://hackage.haskell.org/package/%{tomlreader}/%{tomlreader}.tar.gz Why are these two bundled instead of packaged separately?
Thank you for looking at the package :-) (In reply to Neal Gompa from comment #8) > > Source1: https://hackage.haskell.org/package/%{shellmonad}/%{shellmonad}.tar.gz > > Source2: https://hackage.haskell.org/package/%{tomlreader}/%{tomlreader}.tar.gz > > Why are these two bundled instead of packaged separately? Fair question - mostly me being lazy (it is so hard to get packages reviewed..). Okay going to submit them now.
I linked the reviews. Also I realized since submitting that one is supposed to declare AI usage for Fedora contributions: I did make some use of AI harnesses to write some of the code in this project: though I have reviewed each and every commit carefully and I don't think there is any problematic code. Overall I think the code base is good and the parts I didn't write about as good as I could write. Strong LLMs seem reasonably good at Haskell now: probably the strong typing and API docs help quite a bit. Also I have been using this daily myself - so it has been tested though not so much by others - still well UX feedback. I am also close to releasing 0.5 - though it shouldn't really affect the packaging I think.
Spec URL: https://petersen.fedorapeople.org/reviews/encapsule/encapsule.spec SRPM URL: https://petersen.fedorapeople.org/reviews/encapsule/encapsule-0.5-2.fc46.src.rpm - update to 0.5 and add ncpsl shortname
Spec URL: https://petersen.fedorapeople.org/reviews/encapsule/encapsule.spec SRPM URL: https://petersen.fedorapeople.org/reviews/encapsule/encapsule-0.5.1-2.fc46.src.rpm update to 0.5.1 and unbundle shell-monad & toml-reader
I do have more plans and thoughts on the project since I have been dogfooding it for a good while now. One thing is that I have been pondering to rename its current form to "cntnr" perhaps (it is kind of a generic container dev/user tool). The other part is the ergonomics if one doesn't go pure container native (in the sense of dev environment). What I mean is that as a toolbox replacement, the DX is slightly annoying keeping the image and containers in sync so to speak (think adding build deps etc). Of course if your image is already complete that problem basically goes, but that is not the way I work at least. So I am thinking about experimenting with bubblewrap as an alternative approach to "encapsuling" (isolating) projects, but I don't have experience yet with that so will have to see. Anyway I still think the current iteration has value, but the project approach may evolve or fork possibly going forward. If bwrap works out well it might be more natural to call that encapsule in the end. I just thought I would be transparent about future direction - while also keen to get more feedback on the current UX.
Review notes: * Package follows Fedora Haskell packaging guidelines * Package follows Fedora general packaging guidelines * Package builds and installs * No serious issues from rpmlint PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/encapsule Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
Thank you very much for the review, Neal!
FEDORA-2026-ad082bb407 (encapsule-0.5.1-2.fc45, ghc-shell-monad-0.6.10-3.fc45, and 1 more) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-ad082bb407
FEDORA-2026-ad082bb407 has been pushed to the Fedora 45 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-ad082bb407 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-ad082bb407 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-f359a075cd (encapsule-0.5.1-2.fc44, ghc-shell-monad-0.6.10-3.fc44, and 1 more) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-f359a075cd
https://forge.fedoraproject.org/releng/fedora-scm-requests/issues/1275 f43
FEDORA-2026-df412db030 (encapsule-0.5.1-2.fc43, ghc-shell-monad-0.6.10-3.fc43, and 1 more) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-df412db030
https://forge.fedoraproject.org/releng/fedora-scm-requests/issues/1278 epel10
FEDORA-EPEL-2026-04594c4962 (encapsule-0.5.1-2.el10_4, ghc-shell-monad-0.6.10-3.el10_4, and 1 more) has been submitted as an update to Fedora EPEL 10.4. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-04594c4962
FEDORA-2026-ad082bb407 (encapsule-0.5.1-2.fc45, ghc-shell-monad-0.6.10-3.fc45, and 1 more) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-f359a075cd has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-f359a075cd \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-f359a075cd See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2026-04594c4962 has been pushed to the Fedora EPEL 10.4 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-04594c4962 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-df412db030 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-df412db030 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-df412db030 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-f359a075cd (encapsule-0.5.1-2.fc44, ghc-shell-monad-0.6.10-3.fc44, and 1 more) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2026-04594c4962 (encapsule-0.5.1-2.el10_4, ghc-shell-monad-0.6.10-3.el10_4, and 1 more) has been pushed to the Fedora EPEL 10.4 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-df412db030 (encapsule-0.5.1-2.fc43, ghc-shell-monad-0.6.10-3.fc43, and 1 more) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.