Bug 253692
| Summary: | Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adel Gadllah <adel.gadllah> |
| Component: | Package Review | Assignee: | Warren Togami <wtogami> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | chitlesh, d.bz-redhat, fedora-package-review, krh, leigh123linux, lxtnow, mtasaka, notting, tjb |
| Target Milestone: | --- | Flags: | wtogami:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-09-19 16:13:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 253693 | ||
|
Description
Adel Gadllah
2007-08-21 10:31:32 UTC
fixed a gconf bug, new urls: http://tgmweb.at/gadllah/compiz-fusion.spec http://tgmweb.at/gadllah/compiz-fusion-0.5.2-2.fc7.src.rpm New fixed package: http://tgmweb.at/gadllah/compiz-fusion.spec http://tgmweb.at/gadllah/compiz-fusion-0.5.2-3.fc7.src.rpm Some small fixes: http://tgmweb.at/gadllah/compiz-fusion.spec http://tgmweb.at/gadllah/compiz-fusion-0.5.2-4.fc7.src.rpm Only tried to rebuild on dist-f8 and it seems okay. http://koji.fedoraproject.org/koji/taskinfo?taskID=148783 However, as I am now reviewing some other packages, currently I have no time to review this package. I hope someone will review this. The package looks fine, except the %post, %pre, and %preun scriptlets.
1) Do you really intend on doing --makefile-install-rule in all three places?
Probably not.
2) You should avoid difficult-to-maintain long lists of plugins that are
redundant in the three scriptlets. You could do something like the compiz
package with:
%define core_plugins blur clone cube dbus decoration fade ini inotify
minimize move
for f in %{core_plugins}; do
echo %{_libdir}/compiz/lib$f.so
echo %{_datadir}/compiz/$f.xml
done >> core-files.txt
Then use a loop within the scriptlets to install or uninstall the schemas.
export GCONF_CONFIG_SOURCE=`/usr/bin/gconftool-2 --get-default-source`
for f in %{core_plugins} %{gnome_plugins} core; do
gconftool-2 --makefile-install-rule
%{_sysconfdir}/gconf/schemas/compiz-$f.schemas >& /dev/null || :
done
Fixed in: http://tgmweb.at/gadllah/compiz-fusion.spec http://tgmweb.at/gadllah/compiz-fusion-0.5.2-5.fc7.src.rpm Approved. New Package CVS Request ======================= Package Name: compiz-fusion Short Description: Collection of Compiz Fusion plugins for Compiz Owners: drago01, krh Branches: devel InitialCC: Cvsextras Commits: no Hi Adel, Is it ok for me to request a epel6 branch? https://bugzilla.redhat.com/show_bug.cgi?id=677365 Thanks Leigh (In reply to comment #9) > Hi Adel, > > Is it ok for me to request a epel6 branch? > > https://bugzilla.redhat.com/show_bug.cgi?id=677365 Sure. (In reply to comment #10) > (In reply to comment #9) > > Hi Adel, > > > > Is it ok for me to request a epel6 branch? > > > > https://bugzilla.redhat.com/show_bug.cgi?id=677365 > > Sure. Thank you Package Change Request ====================== Package Name: compiz-fusion New Branches: el6 Owners: leigh123linux Git done (by process-git-requests). |