Bug 2539303
| Summary: | Review Request: libresidfp - Cycle exact SID emulation | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Karel Volný <kvolny> |
| Component: | Package Review | Assignee: | leigh scott <leigh123linux> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bugs.michael, package-review |
| Target Milestone: | --- | Flags: | leigh123linux:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-09-24 11:17:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2537468 | ||
|
Description
Karel Volný
2026-09-23 09:59:55 UTC
Koji build here: https://koji.fedoraproject.org/koji/taskinfo?taskID=150528608 Approved
Spec file looks good.
$ rpmlint '/home/leigh/Downloads/libresidfp-1.2.2-1.fc46.src.rpm'
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
/usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 4 filtered, 0 badness; has taken 0.2 s
$ rpmlint '/home/leigh/Downloads/libresidfp-1.2.2-1.fc46.x86_64.rpm'
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
/usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1
libresidfp.x86_64: E: incorrect-fsf-address /usr/share/doc/libresidfp/README.md
libresidfp.x86_64: E: incorrect-fsf-address /usr/share/licenses/libresidfp/COPYING
1 packages and 0 specfiles checked; 2 errors, 0 warnings, 15 filtered, 2 badness; has taken 0.3 s
The Pagure repository was created at https://src.fedoraproject.org/rpms/libresidfp Monitoring: Anitya project is accessible by this link `https://release-monitoring.org/project/389839` you can modify it manually. Package wasn't created in Anitya, reason: `Bad Request, some necessary arguments were not provided.`. libsidplayfp builds fine with libresidfp-devel as BuildRequires. (In reply to Michael Schwendt from comment #4) > libsidplayfp builds fine with libresidfp-devel as BuildRequires. Are you going to handle audacious-plugins rebuild once libsidplayfp is built with libresidfp support? Yeah, I can do that. ok, rebuilt https://koji.fedoraproject.org/koji/taskinfo?taskID=150554996 guys sorry, I didn't examine the change thoroughly, I thought libsidplayfp can work with sidlite and then use residfp once libresidfp is added, haven't noticed that in fact libsidplayfp needs libresidfp compile time also the so version change caught me by surprise that there are some actual consuments of this exotic thing, I had some brain blackout or what not to check the deps BTW, while at it, audacious checks libresidfp presence, not libresidfp support in libsidplayfp which it actually needs, a little upstrem RFE material ... > BTW, while at it, audacious checks libresidfp presence, not libresidfp support in
> libsidplayfp which it actually needs, a little upstrem RFE material
Not an issue, because the specific headers the SID Plugin needs will only be available if and only if libsidplayfp was built with libresidfp support. They are not part of libresidfp-devel.
|