Bug 2539303 - Review Request: libresidfp - Cycle exact SID emulation
Summary: Review Request: libresidfp - Cycle exact SID emulation
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: leigh scott
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2537468
TreeView+ depends on / blocked
 
Reported: 2026-09-23 09:59 UTC by Karel Volný
Modified: 2026-09-24 11:35 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-09-24 11:17:15 UTC
Type: ---
Embargoed:
leigh123linux: fedora-review+


Attachments (Terms of Use)

Description Karel Volný 2026-09-23 09:59:55 UTC
Spec URL: https://kvolny.fedorapeople.org/libresidfp.spec
SRPM URL: https://kvolny.fedorapeople.org/libresidfp-1.2.2-1.fc46.src.rpm
Description: 
This project is meant to replicate the SID as faithfully as possible while
keeping good performance for realtime use. It is not intended to expose
the chip internal state or adding fancy effects. Both the 6581 and the 8580
models are emulated.

Fedora Account System Username: kvolny

Comment 1 Karel Volný 2026-09-23 10:00:22 UTC
Koji build here: https://koji.fedoraproject.org/koji/taskinfo?taskID=150528608

Comment 2 leigh scott 2026-09-23 10:29:01 UTC
Approved

Spec file looks good.

$ rpmlint '/home/leigh/Downloads/libresidfp-1.2.2-1.fc46.src.rpm' 
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 4 filtered, 0 badness; has taken 0.2 s 


$ rpmlint '/home/leigh/Downloads/libresidfp-1.2.2-1.fc46.x86_64.rpm' 
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

libresidfp.x86_64: E: incorrect-fsf-address /usr/share/doc/libresidfp/README.md
libresidfp.x86_64: E: incorrect-fsf-address /usr/share/licenses/libresidfp/COPYING
 1 packages and 0 specfiles checked; 2 errors, 0 warnings, 15 filtered, 2 badness; has taken 0.3 s

Comment 3 Fedora Admin user for bugzilla script actions 2026-09-23 13:07:30 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/libresidfp
Monitoring:
Anitya project is accessible by this link 
`https://release-monitoring.org/project/389839`
 you can modify it manually.
Package wasn't created in Anitya, reason: `Bad Request, some necessary arguments were not provided.`.

Comment 4 Michael Schwendt 2026-09-23 18:43:38 UTC
libsidplayfp builds fine with libresidfp-devel as BuildRequires.

Comment 5 leigh scott 2026-09-23 18:56:02 UTC
(In reply to Michael Schwendt from comment #4)
> libsidplayfp builds fine with libresidfp-devel as BuildRequires.

Are you going to handle audacious-plugins rebuild once libsidplayfp is built with libresidfp support?

Comment 6 Michael Schwendt 2026-09-23 19:15:19 UTC
Yeah, I can do that.

Comment 7 Karel Volný 2026-09-24 11:17:15 UTC
ok, rebuilt

https://koji.fedoraproject.org/koji/taskinfo?taskID=150554996

guys sorry, I didn't examine the change thoroughly, I thought libsidplayfp can work with sidlite and then use residfp once libresidfp is added, haven't noticed that in fact libsidplayfp needs libresidfp compile time

also the so version change caught me by surprise that there are some actual consuments of this exotic thing, I had some brain blackout or what not to check the deps

BTW, while at it, audacious checks libresidfp presence, not libresidfp support in libsidplayfp which it actually needs, a little upstrem RFE material ...

Comment 8 Michael Schwendt 2026-09-24 11:35:40 UTC
> BTW, while at it, audacious checks libresidfp presence, not libresidfp support in
> libsidplayfp which it actually needs, a little upstrem RFE material 

Not an issue, because the specific headers the SID Plugin needs will only be available if and only if libsidplayfp was built with libresidfp support. They are not part of libresidfp-devel.


Note You need to log in before you can comment on or make changes to this bug.