Bug 2539324

SPEC: https://pbrobinson.fedorapeople.org/python-omegaconf.spec
SRPM: https://pbrobinson.fedorapeople.org/python-omegaconf-2.3.1-1.fc44.src.rpm

koji: https://pbrobinson.fedorapeople.org/python-omegaconf-2.3.1-1.fc44.src.rpm

The Source0 is pointing at a non existing url:
WARNING: Cannot download url: https://github.com/hydra-ecosystem/omegaconf/archive/2.3.1.tar.gz#/omegaconf-2.3.1.tar.gz

I missed a v I think, should be fixed now:

SPEC: https://pbrobinson.fedorapeople.org/python-omegaconf.spec
SRPM: https://pbrobinson.fedorapeople.org/python-omegaconf-2.3.1-1.fc44.src.rpm

Approved. 

Package Review
==============

Issues:
-------
1. [minor, SHOULD] No %check section is present (rpmlint: W: no-%check-section).
2. [minor, cosmetic] `Requires: python3dist(antlr4-python3-runtime)` (spec
   line 20) is redundant: %pyproject_save_files already generates this exact
   dependency automatically from the wheel metadata (Requires-Dist:
   antlr4-python3-runtime>=4.9 is present in METADATA and already appears in
   the automatically generated Requires). Can be dropped.

Neither issue blocks approval.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-omegaconf-2.3.1-1.fc46.noarch.rpm
          python-omegaconf-2.3.1-1.fc46.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
checks: 32, packages: 2

python-omegaconf.spec: W: no-%check-section
 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 11 filtered, 0 badness; has taken 0.4 s


Rpmlint (installed packages)
----------------------------
checks: 33, packages: 1
 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.1 s


Source checksums
----------------
https://github.com/hydra-ecosystem/omegaconf/archive/v2.3.1.tar.gz#/omegaconf-2.3.1.tar.gz :
  CHECKSUM(SHA256) this package     : 3ccd136beb7b7973f341da178d91d5ae78dce7002ba3321386d3920d0eefcec4
  CHECKSUM(SHA256) upstream package : 3ccd136beb7b7973f341da178d91d5ae78dce7002ba3321386d3920d0eefcec4


Requires
--------
python3-omegaconf (rpmlib, GLIBC filtered):
    python(abi)
    python3.15dist(antlr4-python3-runtime)
    python3.15dist(pyyaml)


Provides
--------
python3-omegaconf:
    python-omegaconf
    python3-omegaconf
    python3.15-omegaconf
    python3.15dist(omegaconf)
    python3dist(omegaconf)


Generated by fedora-review 0.12.0 (a08f0fc), manually reviewed and completed
Command line :/usr/bin/fedora-review -b 2539324
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Shell-api, Generic
Disabled plugins: Perl, C/C++, fonts, Haskell, Ocaml, PHP, SugarActivity, R, Java

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-omegaconf
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

> Issues:
> -------
> 1. [minor, SHOULD] No %check section is present (rpmlint: W:
> no-%check-section).
> 2. [minor, cosmetic] `Requires: python3dist(antlr4-python3-runtime)` (spec
>    line 20) is redundant: %pyproject_save_files already generates this exact
>    dependency automatically from the wheel metadata (Requires-Dist:
>    antlr4-python3-runtime>=4.9 is present in METADATA and already appears in
>    the automatically generated Requires). Can be dropped.

I'd already fixed 1) locally but forgot to update the review, fixed 2) before commit

FEDORA-2026-262b0aca20 (python-omegaconf-2.3.1-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-262b0aca20

FEDORA-2026-262b0aca20 has been pushed to the Fedora 45 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-262b0aca20 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-262b0aca20

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.