Bug 254016
| Summary: | Review Request: rubygem-gem_plugin - plugin system based on rubygems | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Scott Seago <sseago> |
| Component: | Package Review | Assignee: | David Lutterkort <lutter> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, hbrock, notting, vanmeeuwen+fedora |
| Target Milestone: | --- | Flags: | lutter:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-11-01 03:50:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 254093 | ||
| Bug Blocks: | 254015 | ||
|
Description
Scott Seago
2007-08-23 17:18:56 UTC
OK - Package name
OK - License info is accurate
OK - License tag is correct and licenses are approved
OK - Specfile name
OK - Specfile is legible
OK - No prebuilt binaries included
OK - BuildRoot value (one of the recommended values)
OK - PreReq not used
OK - Source md5sum matches upstream
OK - No hardcoded pathnames
OK - Package owns all the files it installs
OK - Package requires create needed unowned directories
OK - Package builds successfully on i386 and x86_64 (mock)
OK - BuildRequires sufficient
OK - File permissions set properly (except for rpmlint error below)
OK - Macro usage is consistent
OK - Package is named rubygem-%{gemname}
OK - Source points to full URL of gem
OK - Package version identical with gem version
OK - Package Requires and BuildRequires rubygems
OK - Package provides rubygem(%{gemname}) = %version
OK - Package requires gem dependencies correctly
OK - %prep and %build are empty
OK - %gemdir defined properly, and gem installed into it
OK - Package owns its directories under %gemdir
OK - No arch-specific content in %{gemdir}
OK - Package is noarch
FIX - License files are not installed as %doc
Mark %{geminstdir}/{LICENSE,COPYING} as %doc
FIX - rpmlint complains
E: rubygem-gem_plugin script-without-shebang
/usr/lib/ruby/gems/1.8/gems/gem_plugin-0.2.2/bin/gpgen
Omitting the chmod of %{buildroot}%{geminstdir}/bin/* should do the right
thing
FIX - Requires: rubygem(rake) can not be met since that's not packaged
Fixed listed spec issues. Updated RPM is at: http://people.redhat.com/sseago/fedora/SRPMS/rubygem-gem_plugin-0.2.2-2.fc7.src.rpm rubygem(rake) has been submitted for approval and is now listed as a dependency for this request Excellent. APPROVED Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import the package. Close this bug as RAWHIDE once it's been successfully imported and built. New Package CVS Request ======================= Package Name: rubygem-gem_plugin Short Description: A plugin system based only on rubygems that uses dependencies only Owners: sseago Branches: F-7, EL-5 InitialCC: Cvsextras Commits: cvs done. Package Change Request ====================== Package Name: rubygem-gem_plugin New Branches: EL-4 Owners: sseago, kanarip Approved by sseago in private email cvs done. |