Red Hat Bugzilla – Bug 254015
Review Request: rubygem-mongrel - A small fast HTTP library and server for Ruby
Last modified: 2013-04-30 19:40:05 EDT
Spec URL: http://people.redhat.com/sseago/fedora/spec/rubygem-mongrel.spec SRPM URL: http://people.redhat.com/sseago/fedora/SRPMS/rubygem-mongrel-1.0.1-2.fc7.src.rpm Description: A small fast HTTP library and server that runs Rails, Camping, Nitro and Iowa apps. Note that this is my first package submission -- David Lutterkort has already agreed to sponsor it
Note the following change in the SRPM URL, as I had to bump the rev to deal with some dependency issues: SRPM URL: http://people.redhat.com/sseago/fedora/SRPMS/rubygem-mongrel-1.0.1-3.fc7.src.rpm
OK - Package name OK - License info is accurate OK - License tag is correct and licenses are approved OK - Specfile name OK - Specfile is legible OK - No prebuilt binaries included OK - BuildRoot value (one of the recommended values) OK - PreReq not used OK - Source md5sum matches upstream OK - No hardcoded pathnames OK - Package owns all the files it installs OK - 'Requires' create needed unowned directories OK - Package builds successfully on i386 and x86_64 (mock) OK - BuildRequires sufficient OK - File permissions set properly OK - Macro usage is consistent OK - Package is named rubygem-%{gemname} OK - Source points to full URL of gem OK - Package version identical with gem version OK - Package Requires and BuildRequires rubygems OK - Package provides rubygem(%{gemname}) = %version OK - Package requires gem dependencies correctly OK - %prep and %build are empty OK - %gemdir defined properly, and gem installed into it OK - Package owns its directories under %gemdir OK - No arch specific content in %{gemdir} OK - Defines ruby_sitearch from rbconfig OK - arch specific content moved to %{ruby_sitearch} Package does not produce debuginfo, but given the gyrations of building rubygems that's not practical. FIX - rpmlint is noisy It warns on the srpm about an unapplied patch; that can be ignored since gems can't be patched in a way that rpmlint will notice On the binary RPM, it complains about a number of things that should be fixed FIX - License files are not installed as %doc Mark LICENSE and COPYING as %doc
Fixed listed issues. Updated SRPM is at: http://people.redhat.com/sseago/fedora/SRPMS/rubygem-mongrel-1.0.1-4.fc7.src.rpm
APPROVED Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import the package. Close this bug as RAWHIDE once it's been successfully imported and built.
New Package CVS Request ======================= Package Name: rubygem-mongrel Short Description: A small fast HTTP library and server for Ruby Owners: sseago Branches: F-7, EL-5 InitialCC: Cvsextras Commits: No
cvs done.
Package Change Request ====================== Package Name: rubygem-mongrel New Branches: EL-4 Owners: kanarip