Bug 254019
| Summary: | Review Request: rubygem-daemons - A toolkit to create and control ruby daemons | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Scott Seago <sseago> |
| Component: | Package Review | Assignee: | David Lutterkort <lutter> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, hbrock, notting, vanmeeuwen+fedora |
| Target Milestone: | --- | Flags: | lutter:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-11-01 03:52:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 254015 | ||
|
Description
Scott Seago
2007-08-23 17:21:40 UTC
OK - Package name
OK - Specfile name
OK - Specfile is legible
OK - No prebuilt binaries included
OK - BuildRoot value (one of the recommended values)
OK - PreReq not used
OK - Source md5sum matches upstream
OK - No hardcoded pathnames
OK - Package owns all the files it installs
OK - Package requires create needed unowned directories
OK - Package builds successfully on i386 and x86_64 (mock)
OK - BuildRequires sufficient
OK - File permissions set properly
OK - Macro usage is consistent
OK - rpmlint is silent
OK - Package is named rubygem-%{gemname}
OK - Source points to full URL of gem
OK - Package version identical with gem version
OK - Package Requires and BuildRequires rubygems
OK - Package provides rubygem(%{gemname}) = %version
OK - Package requires gem dependencies correctly
OK - %prep and %build are empty
OK - %gemdir defined properly, and gem installed into it
OK - Package owns its directories under %gemdir
OK - No arch-specific content in %{gemdir}
OK - Package is noarch
FIX - Mark the LICENSE file as %doc
FIX - License info is not accurate
The license seems to be BSD, but not quite. Needs to be clarified
Contrary to what I said above, rpmlint is not silent: E: rubygem-daemons non-executable-script /usr/lib/ruby/gems/1.8/gems/daemons-1.0.7/examples/run/myserver.rb 0644 Since it's just an example, nothing to worry about. Actually, the license for most of the code is MIT; for daemonize.rb it's (GPLv2+ or Ruby) ... the overall license tag therefore is 'MIT and (GPLv2+ or Ruby)' and daemonize.rb's license should be pointed out according to http://fedoraproject.org/wiki/Packaging/LicensingGuidelines?highlight=%28Packaging%29#head-5dcaa7704b32aabaddc2e709f328f48eea6c91de License and spec issues sorted out, SRPM is: http://people.redhat.com/sseago/fedora/SRPMS/rubygem-daemons-1.0.7-2.fc7.src.rpm Excellent. APPROVED Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import the package. Close this bug as RAWHIDE once it's been successfully imported and built. New Package CVS Request ======================= Package Name: rubygem-daemons Short Description: A toolkit to create and control ruby daemons Owners: sseago Branches: F-7, EL-5 InitialCC: Cvsextras Commits: No cvs done. Package Change Request ====================== Package Name: rubygem-daemons New Branches: EL-4 Owners: sseago, kanarip Approved by sseago in private email cvs done. |