Bug 254093
| Summary: | Review Request: rubygem-rake - Ruby based make-like utility | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Lutterkort <lutter> |
| Component: | Package Review | Assignee: | Michael DeHaan <mdehaan> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, hbrock, mtasaka, notting |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | lutter:
fedora_requires_release_note-
mdehaan: fedora-review+ wtogami: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-09-14 22:19:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 254015, 254016 | ||
|
Description
David Lutterkort
2007-08-24 03:05:03 UTC
basics: + rpmlint clean for both src and built RPM + src.rpm builds fine + name good + license + general overview of specfile + docs/changelog Ruby guidelines: + source good + requires/buildrequires good + provides good + prep and build empty + install to gemdir follows guidelines + marked noarch + installs fine + trivial test "rake" runs fine when installed potential things to look at according to packaging doc: - "Ruby packages must require ruby at build time with a BuildRequires: ruby, and may indicate the minimal ruby version they need for building." - "Each Ruby package must indicate the Ruby ABI version it depends on with a line like Requires: ruby(abi) = 1.8" Some of the above is implicit from gem BuildRequires/usage, though I would imagine it can't hurt if the above information is known and set explicitly. Let me know about the above and I'll approve this. Everything else looks fine according to the packaging spec. Thanks for the review .. both of those requires are taken care of by the Requires/BR of rubygems; so listing them again would just be redundant. Works for me. *APPROVED* Bug shouldn't have been closed New Package CVS Request ======================= Package Name: rubygem-rake Short Description: Ruby based make-like utility Owners: lutter, sseago Branches: F-7, EL-5 InitialCC: Cvsextras Commits: yes |