Bug 275211
| Summary: | Review Request: php-channel-phpdb - Adds phpdb channel to PEAR | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexander Kahl <fedora> |
| Component: | Package Review | Assignee: | Remi Collet <fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, fedora-package-review, kevin, lxtnow, notting |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-09-27 01:52:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 256521, 266801, 266821 | ||
|
Description
Alexander Kahl
2007-09-03 14:30:45 UTC
NOT A FORMAL REVIEW (i'm not a sponsor) * no source files * package meets naming and packaging guidelines (no special guideline for channels). * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible (LGPLv2). * BuildRequires are proper. * %clean is present. * package builds in mock (F7 - x86_64). * package installs properly * rpmlint : W: php-channel-phpdb no-documentation * final provides are sane: php-channel(pear.phpdb.org) = 1.0.0-3.fc8 php-channel-phpdb = 1.0.0-3.fc8 * %check is not present; no test suite provide. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear channel..) * no documentation No version for the .xml file, but i think using 1.0.0 is OK. No License but LGPLv2 seems OK as is the license of the package provided on this channel (could be "public domain"). Should : as the version has no meaning, you probably can ommit it in the virtual provides : php-channel(pear.phpdb.org) As you're now sponsored, the above review is a FORMAL REVIEW : APPROVED P.S. Should about provides : php-channel(pear.phpdb.org) still apply. Oups...
Should also add :
Requires(post): %{__pear}
Requires(postun): %{__pear}
Great thanks, I've removed the version number from the virtual Provides. New Package CVS Request ======================= Package Name: php-channel-phing Short Description: Adds phing channel to PEAR Owners: akahl Branches: F-7 EL-4 EL-5 InitialCC: Cvsextras Commits: yes I don't think you could push this to EL-4 (pear really too old), or you need a completely different spec. Alexander: Do you wish to modify your cvs request in light of comment #6? Actually I'm co-maintaining an additional EL-4 system (CentOS 4.5) and wanted to
support it officially, so I'd thought it would be a good idea. If you're saying
EL-4 support is problematic, drop both EL-{4,5} from the cvs request and leave
it as F-7.
How is the procedure to get a separate Spec for EL-4 approved?
Sorry, mistake: The cvs request says "php-channel-phing", I've confused it with Bug 275231; The request should read now: Package Name: php-channel-phpdb Short Description: Adds phpdb channel to PEAR Owners: akahl Branches: F-7 InitialCC: Cvsextras Commits: yes cvs done. There isn't really any procedure to review a seperate spec for el branches. Perhaps you could do some testing and get it all working for epel and then request branches? OK I'll do it that way, thanks for your help Kevin. All builds successful. php-channel-phpdb-1.0.0-4.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. |