Spec URL: http://prelive.iconmobile.com/dev31/fedora-icm-repo/Fedora/7/SPECS/php-channel-phing.spec SRPM URL: http://prelive.iconmobile.com/dev31/fedora-icm-repo/Fedora/7/SRPMS/php-channel-phing-1.0.0-3.fc7.src.rpm Description: This package adds the phing channel which allows PEAR packages from this channel to be installed. -- I'm still searching for a sponsor.
REVIEW * no source files * package meets naming and packaging guidelines (no special guideline for channels). * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible (LGPLv2). * BuildRequires are proper. * %clean is present. * package builds in mock (F7 - x86_64). * package installs properly * rpmlint : W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 9) W: php-channel-phpdb no-documentation * final requires php-cli >= 5.1.4 php-pear(PEAR) * final provides see below php-channel(pear.phing.info) = 1.0.0-3.fc8 php-channel-phing = 1.0.0-3.fc8 * %check is not present; no test suite provide. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear channel..) * no documentation I don't think you need to requires php-cli >= 5.1.4, why this ? Should : correct spec (space/tabs) Requires(post): %{__pear} Requires(postun): %{__pear} Provides: php-channel(pear.phing.info)
Updated Spec URL: http://akahl.fedorapeople.org/php-channel-phing.spec Updated SRPM URL: http://akahl.fedorapeople.org/php-channel-phing-1.0.0-4.fc7.src.rpm Fixed issues: - removed version number in virtual provides - replaced static commands with macros wherever applicable - added post/postun requires for pear - removed redundant version number requirement for php-cli
All issues fixed APPROVED
New Package CVS Request ======================= Package Name: php-channel-phing Short Description: Adds phing channel to PEAR Owners: akahl Branches: F-7 InitialCC: Cvsextras Commits: yes
cvs done.
All builds successful.
php-channel-phing-1.0.0-4.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: php-channel-phing New Branches: EL-6 Owners: cdamian
CVS done (by process-cvs-requests.py).