Bug 278601
| Summary: | Nonstandard behavior of dhcpd init script | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Kundrak <lkundrak> |
| Component: | dhcp | Assignee: | David Cantrell <dcantrell> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bugs.michael, harald |
| Target Milestone: | --- | Keywords: | EasyFix |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-09-26 19:22:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Good catch. I'll work on that later. Thanks for the report. I have been slowly working on making it LSB compliant, but that's sort of a rainy day project honestly. /me waves the not-the-original-author flag :) Fixed in rawhide (dhcp-3.0.6-6.fc8). I've changed the dhcpd and dhcrelay scripts to conform with the Fedora initscript guidelines in addition to removing the unnecessary configtest call you reported. Thanks. *** Bug 246907 has been marked as a duplicate of this bug. *** While running into bug 320761, I've stumbled into this, too. "restart" should call "start" even if "stop" failed. That is, it should attempt a "start" *always*, even if dhcpd is stopped in unknown ways. The way you've changed it, "restart" is like "condrestart" except for the lockfile-check. |
Description of problem: These lines bother me: restart) configtest || exit $? stop start ;; Is it really wise to check configuration and die silently if the check fails? Most services don't do this. Maybe it would be enough if configtest was a bit more verbose, like: 'Checking configuration [FAILED]', or, better, wasn't present at all. There's still a "testconfig" target in case someone wishes to test the config. Version-Release number of selected component (if applicable): dhcp-3.0.6-3.fc8 Additional info: I don't know anything about whether this is or isn't LSB compilant.