Bug 278601 - Nonstandard behavior of dhcpd init script
Summary: Nonstandard behavior of dhcpd init script
Alias: None
Product: Fedora
Classification: Fedora
Component: dhcp
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: David Cantrell
QA Contact: Fedora Extras Quality Assurance
Keywords: EasyFix
: 246907 (view as bug list)
Depends On:
TreeView+ depends on / blocked
Reported: 2007-09-05 15:19 UTC by Lubomir Kundrak
Modified: 2007-11-30 22:12 UTC (History)
2 users (show)

Clone Of:
Last Closed: 2007-09-26 19:22:43 UTC

Attachments (Terms of Use)

Description Lubomir Kundrak 2007-09-05 15:19:55 UTC
Description of problem:

These lines bother me:

        configtest || exit $?

Is it really wise to check configuration and die silently if the check fails?
Most services don't do this. Maybe it would be enough if configtest was a bit
more verbose, like: 'Checking configuration [FAILED]', or, better, wasn't
present at all. There's still a "testconfig" target in case someone wishes to
test the config.

Version-Release number of selected component (if applicable):


Additional info:

I don't know anything about whether this is or isn't LSB compilant.

Comment 1 David Cantrell 2007-09-05 15:26:56 UTC
Good catch.  I'll work on that later.  Thanks for the report.  I have been
slowly working on making it LSB compliant, but that's sort of a rainy day
project honestly.

/me waves the not-the-original-author flag  :)

Comment 2 David Cantrell 2007-09-26 19:22:43 UTC
Fixed in rawhide (dhcp-3.0.6-6.fc8).  I've changed the dhcpd and dhcrelay
scripts to conform with the Fedora initscript guidelines in addition to removing
the unnecessary configtest call you reported.


Comment 3 David Cantrell 2007-09-26 19:23:52 UTC
*** Bug 246907 has been marked as a duplicate of this bug. ***

Comment 5 Michael Schwendt 2007-10-08 15:55:12 UTC
While running into bug 320761, I've stumbled into this, too.

"restart" should call "start" even if "stop" failed. That is,
it should attempt a "start" *always*, even if dhcpd is stopped
in unknown ways.

The way you've changed it, "restart" is like "condrestart" except
for the lockfile-check.

Note You need to log in before you can comment on or make changes to this bug.