Description of problem:
These lines bother me:
configtest || exit $?
Is it really wise to check configuration and die silently if the check fails?
Most services don't do this. Maybe it would be enough if configtest was a bit
more verbose, like: 'Checking configuration [FAILED]', or, better, wasn't
present at all. There's still a "testconfig" target in case someone wishes to
test the config.
Version-Release number of selected component (if applicable):
I don't know anything about whether this is or isn't LSB compilant.
Good catch. I'll work on that later. Thanks for the report. I have been
slowly working on making it LSB compliant, but that's sort of a rainy day
/me waves the not-the-original-author flag :)
Fixed in rawhide (dhcp-3.0.6-6.fc8). I've changed the dhcpd and dhcrelay
scripts to conform with the Fedora initscript guidelines in addition to removing
the unnecessary configtest call you reported.
*** Bug 246907 has been marked as a duplicate of this bug. ***
While running into bug 320761, I've stumbled into this, too.
"restart" should call "start" even if "stop" failed. That is,
it should attempt a "start" *always*, even if dhcpd is stopped
in unknown ways.
The way you've changed it, "restart" is like "condrestart" except
for the lockfile-check.