Bug 285331
| Summary: | Review Request: jack-rack - Stereo LADSPA effects rack for the JACK audio API | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Chauvet (kwizart) <kwizart> |
| Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, green, hdegoede, kms, nando, notting |
| Target Milestone: | --- | Flags: | hdegoede:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-10-12 08:57:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 321931 | ||
| Bug Blocks: | |||
|
Description
Nicolas Chauvet (kwizart)
2007-09-10 22:57:24 UTC
This would seem to be a duplicate of bug 232358. I've add a comment to bug 232358 to try and coordinate this. Ok, bug 232358 isn't going anywhere fast, so I've closed it, and I'll review this. okay, I've done a full review: Must Fix: --------- * Doesn't build on devel (as already discussed by mail) I fixed thi by adding this line to %setup: sed -i 's/-DGTK_DISABLE_DEPRECATED=1//g' src/Makefile.* * Set vendor to Fedora when installing .desktop file * jack-rack.x86_64: W: file-not-utf8 /usr/share/doc/jack-rack-1.4.6/NEWS * License: should be GPLv2+ * .desktop file Categories, drop the Utility, what did CCRMA have here? If they had some special X-Foo entries, please preserve these. Should Fix: ------------ * Drop the "Encoding=.." from the ,desktop, this is deprecated Spec URL: http://kwizart.free.fr/fedora/6/testing/jack-rack/jack-rack.spec SRPM URL: http://kwizart.free.fr/fedora/6/testing/jack-rack/jack-rack-1.4.6- 2.kwizart.fc6.src.rpm Description: Stereo LADSPA effects rack for the JACK audio API There is another dependency with ladcca, But i don't know if it is required The others issues are solved (In reply to comment #5) > There is another dependency with ladcca, But i don't know if it is required > The others issues are solved Well, then we just need to get that reviewed first :) Add a update request for lash! Can someone add a potential list of package that need a rebuild if we update it before F8 to be gold ? (rawhide installation not ready)... Nicolas, Can you please post a proposal to update lash to the fedora-devel list? I think this needs to be discussed considering the fact that we are post test3. Don't get me wrong, I would really like to see this get in F-8 esp. with the CCRMA merger in mind. (In reply to comment #7) > Add a update request for lash! > Can someone add a potential list of package that need a rebuild if we update it > before F8 to be gold ? (rawhide installation not ready)... lash has been updated to 0.5.3 in rawhide. I've also rebuilt all of my packages depending on lash (fluidsynth, seq24, vkeybd, dssi and zynaddsubfx). Nicolas can you do a new (and hopefully last) version against the new lash? Then I'll take a look at it and approve it. FWIW, I think the DTD file for jack-rack should be moved from /usr/share/dtds to /usr/share/xml/jack-rack. See http://www.pathname.com/fhs/pub/fhs-2.3.html#AEN2007 and several other packages that install DTD files (like lash). Thanks for asking about this Nicolas. Spec URL: http://kwizart.free.fr/fedora/6/testing/jack-rack/jack-rack.spec SRPM URL: http://kwizart.free.fr/fedora/6/testing/jack-rack/jack-rack-1.4.6-3.fc7.src.rpm Description: Stereo LADSPA effects rack for the JACK audio API So I moved the dsdt dir to %{_datadir}/xml/jack-rack/dtds (same as lash do now). Looks fine now: approved! thx for the review: New Package CVS Request ======================= Package Name: jack-rack Short Description: Stereo LADSPA effects rack for the JACK audio API Owners: kwizart nando Branches: F-7 devel InitialCC: <empty> Cvsextras Commits: Yes cvs done. Imported and built for F-8 Fernando, if you want to build it for F-7, I will do it... (In reply to comment #16) > Imported and built for F-8 > Fernando, if you want to build it for F-7, I will do it... It'd be great if you could do that... I guess fc6 is out of the loop, right? I'm still supporting it so if you can't build for that I'll build from your .src.rpm here. Ok, doing for FC-6 also... Package Change Request ====================== Package Name: jack-rack New Branches: FC-6 cvs done. |