Bug 305531
| Summary: | Review Request: bluecurve-gdm-theme - Bluecurve GDM theme | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ray Strode [halfline] <rstrode> |
| Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mclasen:
fedora-review+
notting: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-10-11 15:39:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 305441 | ||
|
Description
Ray Strode [halfline]
2007-09-25 17:05:58 UTC
rpmlint is silent package name: ok spec file name: ok packaging guidelines: ok license: ok license field: ok license file: must be included spec language: ok spec readable: yes upstream sources: no upstream yet buildable: ok ExcludeArch: n/a BRs: must add perl(XML::Parser) locales: ok shared libs: n/a relocatable: n/a directory ownership: ok %file: ok permissions: ok %clean: ok macro use: ok content: permissible large docs: n/a %doc: ok header files: n/a static libs: n/a pc files: n/a shared libs: n/a devel package: n/a libtool archives: n/a gui apps: n/a directory ownership: ok %install: ok utf8 filenames: ok should the Requires: fedora-logos be Requires: system-logos instead ? adding COPYING and BuildRequires. We want fedora-logos because the theme is Fedora branded by design. Well, maybe. The other gdm themes definitely. Bluecurve is debatable actually. What do you think? Well, it doesn't actually use a *trademarked* logo (this is just the old Fedora font on a big blue background, right?) Okay, yea, let's make this one system-logos then. No, I mean if it's not trademarked, you can just put the graphic in the theme. Or leave it in fedora-logos, either or. ah right, that's even nicer I made the change suggested in comment 5, fwiw (and the similar change for the kdm theme) Approved New Package CVS Request ======================= Package Name: bluecurve-gdm-theme Short Description: Bluecurve-gdm-theme Owners: rstrode,davidz Branches: InitialCC: Cvsextras Commits: no done |