Bug 305771

Summary:	Review Request: fedora-screensaver-theme - Fedora screensaver theme
Product:	[Fedora] Fedora	Reporter:	Ray Strode [halfline] <rstrode>
Component:	Package Review	Assignee:	Matthias Clasen <mclasen>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	mclasen: fedora-review+ notting: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-10-11 16:02:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	305441

Description Ray Strode [halfline] 2007-09-25 17:59:15 UTC

Spec URL:
http://rstrode.fedorapeople.org/fedora-screensaver-theme/checkout/fedora-screensaver-theme.spec

SRPM URL:
http://rstrode.fedorapeople.org/fedora-screensaver-theme/checkout/fedora-screensaver-theme-1.0.0-1.fc8.src.rpm

Description:
This package contains a Fedora branded screensaver theme.

Comment 1 Matthias Clasen 2007-09-26 23:23:43 UTC


rpmlint output:
/var/lib/mock/fedora-development-i386/result/fedora-screensaver-theme-1.0.0-1.fc8.noarch.rpm

fedora-screensaver-theme.noarch: W: invalid-license GPL
fedora-screensaver-theme.noarch: E: invalid-desktopfile
/usr/share/applications/screensavers/system.desktop

package name: ok
spec file name: ok
packaging guidelines: see above, the desktop file should be fixed by
  adding a semicolon at the end of the Categories list
license: ok 
license field: must be fixed
license file: ok
spec language: ok
spec legibility: ok
upstream sources: no upstream yet
buildable: yes
ExcludeArch: n/a
relocatable: n/a
directory ownership: ok
%files: ok
permissions: ok
%clean: ok
macro use: consistent
content: permissible
large docs: n/a
%doc: ok
headers: n/a
static libs: n/a
pc files: n/a
shared libs: n/a
libtool archives: ok
gui apps: n/a
directories: ok
%install: ok
utf8 filenames: ok

Fix the license and the desktop file, then it is approved.

Comment 2 Ray Strode [halfline] 2007-10-09 16:10:44 UTC

New Package CVS Request
=======================
Package Name: fedoa-screensaver-theme
Short Description: Fedora screensaver theme
Owners: rstrode,davidz
Branches:
InitialCC:
Cvsextras Commits: no

Comment 3 Bill Nottingham 2007-10-09 21:35:20 UTC

done