Bug 308851
| Summary: | matchpathcon dereferences NULL in case there's no file_contexts file | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Kundrak <lkundrak> | ||||
| Component: | libselinux | Assignee: | Daniel Walsh <dwalsh> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | mmalik | ||||
| Target Milestone: | --- | Keywords: | EasyFix, Patch | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Current | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-01-21 15:44:44 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Created attachment 208381 [details]
Fix to matchpathcon NULL pointer dereference
Applied fix to libselinux-2.0.35-2 Daniel: what about the dependency on selinux-policy-targeted? Not sure what you mean. This is a fix in the shared libraries, All apps that use the library will inherit the fix. |
Description of problem: matchpathcon needs /etc/selinux/targeted/contexts/files/file_contexts from selinux-policy-targeted package to work. When it's not present, it fails, and crashes when dereferencing the handle it failed to initialize before. Version-Release number of selected component (if applicable): libselinux-2.0.34-3.fc8 How reproducible: Steps to Reproduce: 1. ensure that you don't have selinux-policy-targeted package 2. matchpathcon /dev/null Actual results: open("/etc/selinux/targeted/contexts/files/file_contexts", O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) write(2, "matchpathcon(/mnt) failed: No su"..., 53matchpathcon(/mnt) failed: No such file or directory ) = 53 --- SIGSEGV (Segmentation fault) @ 0 (0) --- +++ killed by SIGSEGV (core dumped) +++ Additional info: I attach the patch to prevent the segfault. Additionaly, maybe it would be a good idea if libselinux depended on selinux-policy-targeted.