Bug 308851 - matchpathcon dereferences NULL in case there's no file_contexts file
Summary: matchpathcon dereferences NULL in case there's no file_contexts file
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: libselinux
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Daniel Walsh
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-09-27 12:37 UTC by Lubomir Kundrak
Modified: 2011-02-14 14:42 UTC (History)
1 user (show)

Fixed In Version: Current
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-01-21 15:44:44 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Fix to matchpathcon NULL pointer dereference (447 bytes, patch)
2007-09-27 12:39 UTC, Lubomir Kundrak
no flags Details | Diff

Description Lubomir Kundrak 2007-09-27 12:37:38 UTC
Description of problem:

matchpathcon needs /etc/selinux/targeted/contexts/files/file_contexts from
selinux-policy-targeted package to work. When it's not present, it fails, and
crashes when dereferencing the handle it failed to initialize before.

Version-Release number of selected component (if applicable):

libselinux-2.0.34-3.fc8

How reproducible:


Steps to Reproduce:
1. ensure that you don't have selinux-policy-targeted package
2. matchpathcon /dev/null
  
Actual results:

open("/etc/selinux/targeted/contexts/files/file_contexts", O_RDONLY|O_LARGEFILE)
= -1 ENOENT (No such file or directory)
write(2, "matchpathcon(/mnt) failed: No su"..., 53matchpathcon(/mnt) failed: No
such file or directory
) = 53
--- SIGSEGV (Segmentation fault) @ 0 (0) ---
+++ killed by SIGSEGV (core dumped) +++

Additional info:

I attach the patch to prevent the segfault. Additionaly, maybe it would be a
good idea if libselinux depended on selinux-policy-targeted.

Comment 1 Lubomir Kundrak 2007-09-27 12:39:47 UTC
Created attachment 208381 [details]
Fix to matchpathcon NULL pointer dereference

Comment 2 Daniel Walsh 2007-09-27 17:56:04 UTC
Applied fix to libselinux-2.0.35-2

Comment 3 Lubomir Kundrak 2007-09-28 11:42:07 UTC
Daniel: what about the dependency on selinux-policy-targeted?

Comment 4 Daniel Walsh 2007-09-28 13:25:46 UTC
Not sure what you mean.  This is a fix in the shared libraries,  All apps that
use the library will inherit the fix.


Note You need to log in before you can comment on or make changes to this bug.