Bug 313201

Summary:	Review Request: aasaver - A screensaver for KDE which presents an ASCII aquarium
Product:	[Fedora] Fedora	Reporter:	Ian Chapman <packages>
Component:	Package Review	Assignee:	Marc Bradshaw <fedora>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, mtasaka, notting
Target Milestone:	---	Flags:	fedora: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-10-02 20:02:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ian Chapman 2007-09-30 17:46:11 UTC

Spec URL: http://dribble.org.uk/reviews/aasaver.spec
SRPM URL: http://dribble.org.uk/reviews/aasaver-0.3.2-1.src.rpm
Description: 

KDE Asciiquarium is a KDE screensaver based on Kirk Baucom's fabulous
asciiquarium program (http://www.robobunny.com/projects/asciiquarium/). It's a
simulation of an animated ocean scene using ASCII art.


rpmlint info:
E: aasaver configure-without-libdir-spec
W: aasaver no-documentation
E: aasaver file-in-usr-marked-as-conffile
/usr/share/config.kcfg/asciiquarium.kcfg

These can all be ignored because:

1. The configure script is NOT a normal configure script
2. There is no documentation
3. It's a KDE configuration file so doesn't reside in /etc

Comment 1 Marc Bradshaw 2007-10-02 10:44:41 UTC

OK -  Meets Packaging Guidelines.
OK -  Package named correctly
NA -  Patches named correctly
      No Patches
OK -  Spec file named correctly to match base
OK -  License is valid
OK -  Licence field matches package
OK *1 Licence file installed if supplied
OK -  Spec file in American English
OK -  Source matches upstream (md5)
      dfc6780c196883f25ec01b4663dfaca3
NA -  Locales use %find_lang
      No Locales
OK -  %clean is present and correct
OK -  Package has correct buildroot.
OK -  Specfile Legible
OK -  Builds in Mock
      F7-i386
NA -  %post/%postun calls ldconfig for sh libs
      No sh libs
NA -  Owns directories it creates
      Creates no directories
OK -  No duplicate files
OK -  Has %defattr and has correct permissions
OK -  Macros used consistantly
NA -  %doc does not affect runtime
      No Docs
NA -  Headers/static libs in -devel
NA -  .pc files in -devel
NA -  .so files in -devel
NA -  -devel requires base
      No -devel
OK -  Contains no .la libtool archive files
OK -  Does not own others files
OK -  .desktop files installed correctly
OK -  BuildRequires correct.
OK -  Package is code or permissible content.
OK -  Package has rm -rf %{buildroot} at top of %install.
OK -  Package compiles and builds on at least one arch.
      F&-i386
OK *2 rpmlint output.
NA -  documentation in -doc package
      No documentation
OK -  final provides and requires are sane.
OK -  should have dist tag
OK -  should package latest version

*1 No License file included by upstream, consider contacting upstream about this.

*2 Warnings as expected are explained in review.

APPROVED

Comment 2 Ian Chapman 2007-10-02 13:01:19 UTC

Thanks for the review

Comment 3 Ian Chapman 2007-10-02 13:05:31 UTC

New Package CVS Request
=======================
Package Name: aasaver
Short Description: A screensaver for KDE which presents an ASCII aquarium
Owners: oddsocks
Branches: FC-6 F-7
InitialCC: <empty>
Cvsextras Commits: yes

Comment 4 Kevin Fenzi 2007-10-02 16:04:58 UTC

cvs done.

Comment 5 Ian Chapman 2007-10-02 20:02:12 UTC

Imported.