Spec URL: http://dribble.org.uk/reviews/aasaver.spec SRPM URL: http://dribble.org.uk/reviews/aasaver-0.3.2-1.src.rpm Description: KDE Asciiquarium is a KDE screensaver based on Kirk Baucom's fabulous asciiquarium program (http://www.robobunny.com/projects/asciiquarium/). It's a simulation of an animated ocean scene using ASCII art. rpmlint info: E: aasaver configure-without-libdir-spec W: aasaver no-documentation E: aasaver file-in-usr-marked-as-conffile /usr/share/config.kcfg/asciiquarium.kcfg These can all be ignored because: 1. The configure script is NOT a normal configure script 2. There is no documentation 3. It's a KDE configuration file so doesn't reside in /etc
OK - Meets Packaging Guidelines. OK - Package named correctly NA - Patches named correctly No Patches OK - Spec file named correctly to match base OK - License is valid OK - Licence field matches package OK *1 Licence file installed if supplied OK - Spec file in American English OK - Source matches upstream (md5) dfc6780c196883f25ec01b4663dfaca3 NA - Locales use %find_lang No Locales OK - %clean is present and correct OK - Package has correct buildroot. OK - Specfile Legible OK - Builds in Mock F7-i386 NA - %post/%postun calls ldconfig for sh libs No sh libs NA - Owns directories it creates Creates no directories OK - No duplicate files OK - Has %defattr and has correct permissions OK - Macros used consistantly NA - %doc does not affect runtime No Docs NA - Headers/static libs in -devel NA - .pc files in -devel NA - .so files in -devel NA - -devel requires base No -devel OK - Contains no .la libtool archive files OK - Does not own others files OK - .desktop files installed correctly OK - BuildRequires correct. OK - Package is code or permissible content. OK - Package has rm -rf %{buildroot} at top of %install. OK - Package compiles and builds on at least one arch. F&-i386 OK *2 rpmlint output. NA - documentation in -doc package No documentation OK - final provides and requires are sane. OK - should have dist tag OK - should package latest version *1 No License file included by upstream, consider contacting upstream about this. *2 Warnings as expected are explained in review. APPROVED
Thanks for the review
New Package CVS Request ======================= Package Name: aasaver Short Description: A screensaver for KDE which presents an ASCII aquarium Owners: oddsocks Branches: FC-6 F-7 InitialCC: <empty> Cvsextras Commits: yes
cvs done.
Imported.