Bug 313211

Summary:	Review Request: kbiof - KDE port of the original BIOF XScreenSaver
Product:	[Fedora] Fedora	Reporter:	Ian Chapman <packages>
Component:	Package Review	Assignee:	Marc Bradshaw <fedora>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, mtasaka, notting, rdieter
Target Milestone:	---	Flags:	fedora: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-10-02 20:01:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ian Chapman 2007-09-30 17:50:53 UTC

Spec URL: http://dribble.org.uk/reviews/kbiof.spec
SRPM URL: http://dribble.org.uk/reviews/kbiof-0.3-1.src.rpm
Description: 

An OpenGL screensaver for KDE which displays 3D primitives in animated patterns


rpmlint info:
W: kbiof dangling-relative-symlink /usr/share/doc/HTML/en/kbiof/common ../common

This can be ignored and is normal for most KDE apps because it points to a file in another KDE package

Comment 1 Mamoru TASAKA 2007-10-01 13:53:22 UTC

This is for KDE screensaver only.

Comment 2 Marc Bradshaw 2007-10-02 10:50:18 UTC

OK -  Meets Packaging Guidelines.
OK -  Package named correctly
NA -  Patches named correctly
      No Patches
OK -  Spec file named correctly to match base
OK -  License is valid
OK -  Licence field matches package
OK -  Licence file installed if supplied
OK -  Spec file in American English
OK -  Source matches upstream (md5)
      dd9bf4afca5bdbb95b6ae4f5cbe515b7
NA -  Locales use %find_lang
      No locales
OK -  %clean is present and correct
OK -  Package has correct buildroot.
OK -  Specfile Legible
OK -  Builds in Mock
      F&-i386
NA -  %post/%postun calls ldconfig for sh libs
      No sh libs
OK -  Owns directories it creates
OK -  No duplicate files
OK -  Has %defattr and has correct permissions
OK -  Macros used consistantly
OK -  %doc does not affect runtime
NA -  Headers/static libs in -devel
NA -  .pc files in -devel
NA -  .so files in -devel
NA -  -devel requires base
      No devel
OK -  Contains no .la libtool archive files
OK -  Does not own others files
OK -  .desktop files installed correctly
OK -  BuildRequires correct.
OK -  Package is code or permissible content.
OK -  Package has rm -rf %{buildroot} at top of %install.
OK -  Package compiles and builds on at least one arch.
      F&-i386
OK -  rpmlint output.
      1 Warning as explained in review.
NA -  documentation in -doc package
OK -  final provides and requires are sane.
OK -  should have dist tag
OK -  should package latest version

APPROVED

Comment 3 Ian Chapman 2007-10-02 13:01:30 UTC

Thanks for the review

Comment 4 Ian Chapman 2007-10-02 13:06:28 UTC

New Package CVS Request
=======================
Package Name: kbiof
Short Description: KDE port of the original BIOF XScreenSaver
Owners: oddsocks
Branches: FC-6 F-7
InitialCC: <empty>
Cvsextras Commits: yes

Comment 5 Kevin Fenzi 2007-10-02 16:07:36 UTC

cvs done.

Comment 6 Ian Chapman 2007-10-02 20:01:47 UTC

Imported.