Red Hat Bugzilla – Bug 313211
Review Request: kbiof - KDE port of the original BIOF XScreenSaver
Last modified: 2007-11-30 17:12:17 EST
Spec URL: http://dribble.org.uk/reviews/kbiof.spec SRPM URL: http://dribble.org.uk/reviews/kbiof-0.3-1.src.rpm Description: An OpenGL screensaver for KDE which displays 3D primitives in animated patterns rpmlint info: W: kbiof dangling-relative-symlink /usr/share/doc/HTML/en/kbiof/common ../common This can be ignored and is normal for most KDE apps because it points to a file in another KDE package
This is for KDE screensaver only.
OK - Meets Packaging Guidelines. OK - Package named correctly NA - Patches named correctly No Patches OK - Spec file named correctly to match base OK - License is valid OK - Licence field matches package OK - Licence file installed if supplied OK - Spec file in American English OK - Source matches upstream (md5) dd9bf4afca5bdbb95b6ae4f5cbe515b7 NA - Locales use %find_lang No locales OK - %clean is present and correct OK - Package has correct buildroot. OK - Specfile Legible OK - Builds in Mock F&-i386 NA - %post/%postun calls ldconfig for sh libs No sh libs OK - Owns directories it creates OK - No duplicate files OK - Has %defattr and has correct permissions OK - Macros used consistantly OK - %doc does not affect runtime NA - Headers/static libs in -devel NA - .pc files in -devel NA - .so files in -devel NA - -devel requires base No devel OK - Contains no .la libtool archive files OK - Does not own others files OK - .desktop files installed correctly OK - BuildRequires correct. OK - Package is code or permissible content. OK - Package has rm -rf %{buildroot} at top of %install. OK - Package compiles and builds on at least one arch. F&-i386 OK - rpmlint output. 1 Warning as explained in review. NA - documentation in -doc package OK - final provides and requires are sane. OK - should have dist tag OK - should package latest version APPROVED
Thanks for the review
New Package CVS Request ======================= Package Name: kbiof Short Description: KDE port of the original BIOF XScreenSaver Owners: oddsocks Branches: FC-6 F-7 InitialCC: <empty> Cvsextras Commits: yes
cvs done.
Imported.