Bug 313221
Summary: | Review Request: qstars - A screensaver simulating planets and asteroids in space | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ian Chapman <packages> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, mtasaka, notting, rdieter |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-10-07 18:26:28 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ian Chapman
2007-09-30 17:54:39 UTC
Perhaps this can also support xscreensaver (so gnome-screensaver). Would you check the following? http://mtasaka.fedorapeople.org/Review_request/qstars/qstars-0.4-2.fc7.src.rpm http://mtasaka.fedorapeople.org/Review_request/qstars/qstars.spec If your Kxscreensaver works well with the srpm above, I will proceed to review qstars. Thanks for that, it still works perfectly with KDE. Here's the latest version. I've just made a few whitespace changes and some minor changes to the descriptions, otherwise it's essentially identical to yours. Spec URL: http://dribble.org.uk/reviews/qstars.spec SRPM URL: http://dribble.org.uk/reviews/qstars-0.4-3.src.rpm Okay. ------------------------------------------------------------- This package (qstars) is APPROVED by me ------------------------------------------------------------- Thanks for the review! New Package CVS Request ======================= Package Name: qstars Short Description: A screensaver simulating planets and asteroids in space Owners: oddsocks Branches: FC6 F7 InitialCC: <empty> Cvsextras Commits: Yes theres a bug in the gnome-screensaver part atleast: cat /usr/share/applications/screensavers/qstars-gss.desktop |grep Name Name=tempest typical copy&paste error i guess. id recommend to look at the other files aswell (umm it still doesent work in gnome-screensaver for me though) (In reply to comment #7) > (umm it still doesent work in gnome-screensaver for me though) Then simply killing gnome-screensaver support is a best solution. Honestly saying, I don't care about gnome-screensaver. Well, maybe the simple "vroot.h" method used in qstars (which works with xscrensaver) no longer works with gnome-screensaver. I've played around a bit and i can't get it to work with gnome either. There seems to be two issues, the first one is that gnome appears to need the binary to be in /usr/libexec/gnome-screensavers otherwise it doesn't bother to execute it. Secondly, it simply just doesn't appear to be compatible. I can actually get it to run but nothing is displayed. So for now I'll remove gnome support before import. It can always be added later if a fix/workaround is discovered. Spec URL: http://dribble.org.uk/reviews/qstars.spec SRPM URL: http://dribble.org.uk/reviews/qstars-0.4-3.src.rpm Gnome support has been removed. I haven't bumped the EVR but can you give it a quick look to make sure its still OK. I guess the cvs flag got cleared because of additional comments. (In reply to comment #11) > Spec URL: http://dribble.org.uk/reviews/qstars.spec > SRPM URL: http://dribble.org.uk/reviews/qstars-0.4-3.src.rpm > > Gnome support has been removed. I haven't bumped the EVR but can you give it a > quick look to make sure its still OK. I guess the cvs flag got cleared because > of additional comments. Okay. (Resetting cvs flag) New Package CVS Request ======================= Package Name: qstars Short Description: A screensaver simulating planets and asteroids in space Owners: oddsocks Branches: FC6 F7 InitialCC: <empty> Cvsextras Commits: Yes cvs done. Please close this bug when rebuild is done and request for bodhi is done. Imported and built |