Bug 313221 - Review Request: qstars - A screensaver simulating planets and asteroids in space
Summary: Review Request: qstars - A screensaver simulating planets and asteroids in space
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-09-30 17:54 UTC by Ian Chapman
Modified: 2007-11-30 22:12 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-10-07 18:26:28 UTC
Type: ---
Embargoed:
mtasaka: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Ian Chapman 2007-09-30 17:54:39 UTC
Spec URL: http://dribble.org.uk/reviews/qstars.spec
SRPM URL: http://dribble.org.uk/reviews/qstars-0.4-1.src.rpm
Description: 

A screensaver for KDE which simulates planets, asteroids and ships in a moving
starfield

Comment 1 Mamoru TASAKA 2007-10-01 13:47:31 UTC
Perhaps this can also support xscreensaver (so gnome-screensaver).

Comment 2 Mamoru TASAKA 2007-10-01 16:22:08 UTC
Would you check the following?

http://mtasaka.fedorapeople.org/Review_request/qstars/qstars-0.4-2.fc7.src.rpm
http://mtasaka.fedorapeople.org/Review_request/qstars/qstars.spec

If your Kxscreensaver works well with the srpm above, I will
proceed to review qstars.

Comment 3 Ian Chapman 2007-10-01 19:05:53 UTC
Thanks for that, it still works perfectly with KDE. Here's the latest version.
I've just made a few whitespace changes and some minor changes to the
descriptions, otherwise it's essentially identical to yours.

Spec URL: http://dribble.org.uk/reviews/qstars.spec
SRPM URL: http://dribble.org.uk/reviews/qstars-0.4-3.src.rpm

Comment 4 Mamoru TASAKA 2007-10-02 16:08:44 UTC
Okay.

-------------------------------------------------------------
    This package (qstars) is APPROVED by me
-------------------------------------------------------------

Comment 5 Ian Chapman 2007-10-02 18:37:48 UTC
Thanks for the review!

Comment 6 Ian Chapman 2007-10-02 18:39:24 UTC
New Package CVS Request
=======================
Package Name: qstars
Short Description: A screensaver simulating planets and asteroids in space
Owners: oddsocks
Branches: FC6 F7
InitialCC: <empty>
Cvsextras Commits: Yes

Comment 7 Rudolf Kastl 2007-10-02 19:51:50 UTC
theres a bug in the gnome-screensaver part atleast:

cat /usr/share/applications/screensavers/qstars-gss.desktop |grep Name
Name=tempest

typical copy&paste error i guess. id recommend to look at the other files aswell
(umm it still doesent work in gnome-screensaver for me though)



Comment 8 Mamoru TASAKA 2007-10-02 20:21:07 UTC
(In reply to comment #7)
>  (umm it still doesent work in gnome-screensaver for me though)

Then simply killing gnome-screensaver support is a best solution.
Honestly saying, I don't care about gnome-screensaver.



Comment 9 Mamoru TASAKA 2007-10-02 20:35:21 UTC
Well, maybe the simple "vroot.h" method used in qstars
(which works with xscrensaver) no longer works with gnome-screensaver.

Comment 10 Ian Chapman 2007-10-02 23:49:37 UTC
I've played around a bit and i can't get it to work with gnome either. There
seems to be two issues, the first one is that gnome appears to need the binary
to be in /usr/libexec/gnome-screensavers otherwise it doesn't bother to execute it.

Secondly, it simply just doesn't appear to be compatible. I can actually get it
to run but nothing is displayed. So for now I'll remove gnome support before
import. It can always be added later if a fix/workaround is discovered.



Comment 11 Ian Chapman 2007-10-03 21:51:07 UTC
Spec URL: http://dribble.org.uk/reviews/qstars.spec
SRPM URL: http://dribble.org.uk/reviews/qstars-0.4-3.src.rpm

Gnome support has been removed. I haven't bumped the EVR but can you give it a
quick look to make sure its still OK. I guess the cvs flag got cleared because
of additional comments.

Comment 12 Mamoru TASAKA 2007-10-04 06:00:34 UTC
(In reply to comment #11)
> Spec URL: http://dribble.org.uk/reviews/qstars.spec
> SRPM URL: http://dribble.org.uk/reviews/qstars-0.4-3.src.rpm
> 
> Gnome support has been removed. I haven't bumped the EVR but can you give it a
> quick look to make sure its still OK. I guess the cvs flag got cleared because
> of additional comments.

Okay.


Comment 13 Mamoru TASAKA 2007-10-04 06:01:11 UTC
(Resetting cvs flag)

Comment 14 Ian Chapman 2007-10-04 14:34:33 UTC
New Package CVS Request
=======================
Package Name: qstars
Short Description: A screensaver simulating planets and asteroids in space
Owners: oddsocks
Branches: FC6 F7
InitialCC: <empty>
Cvsextras Commits: Yes

Comment 15 Kevin Fenzi 2007-10-04 23:22:57 UTC
cvs done.

Comment 16 Mamoru TASAKA 2007-10-06 11:59:38 UTC
Please close this bug when rebuild is done and request for
bodhi is done.

Comment 17 Ian Chapman 2007-10-07 18:26:28 UTC
Imported and built


Note You need to log in before you can comment on or make changes to this bug.