Bug 313481
| Summary: | Review Request: aget - Console download accelerator | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rahul Sundaram <sundaram> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, fedora-package-review, notting, smohan |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-10-04 23:52:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Rahul Sundaram
2007-10-01 04:16:31 UTC
First impressions.
%{name} macro should be used in Source: URL.
%{?dist} not used in Release: tag. (not mandatory or course, but can be useful)
%{optflags} are not used in make.
Patch file should be prefixed with the package name.
Thanks for the review. Updated as per review http://sundaram.fedorapeople.org/aget.spec http://sundaram.fedorapeople.org/aget-0.4-2.src.rpm Change Release line to
Release: 2%{?dist}
and Change defattr line to
%defattr(-, root, root, -)
and rpmlint gave me aget.i386: E: description-line-too-long Aget is a multi-threaded download accelerator like Flashget. It supports HTTP downloads and can be run from the console. ===>Your description lines must not exceed 79 characters. If a line is exceeding this number, cut it to fit in two lines. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 1d32390f5ea2ddd82dfbb1794cdfa92f aget-0.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED. New Package CVS Request ======================= Package Name: aget Short Description: Console download accelerator Owners: sundaram Branches: F-7 EL-4 EL-5 InitialCC: Cvsextras Commits: yes Rahul, Learn first how to use Bugzilla, at least how and when to set/reset flags. You reverted fedora-review+ flag set by me. Thanks mtasaka for correcting them. I set the flag on fedora-review instead of fedora-cvs accidently. Confusing docs don't help either. cvs done. |