Bug 313481 - Review Request: aget - Console download accelerator
Review Request: aget - Console download accelerator
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2007-10-01 00:16 EDT by Rahul Sundaram
Modified: 2013-03-13 01:42 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-10-04 19:52:01 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mtasaka: fedora‑review+
kevin: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Rahul Sundaram 2007-10-01 00:16:31 EDT
Spec URL: http://sundaram.fedorapeople.org/aget.spec
SRPM URL: http://sundaram.fedorapeople.org/aget-0.4-1.src.rpm
Description: Aget is a multi-threaded download accelerator like Flashget. It supports HTTP downloads and can be run from the console.
Comment 1 Marc Bradshaw 2007-10-01 00:54:00 EDT
First impressions.

%{name} macro should be used in Source: URL.
%{?dist} not used in Release: tag. (not mandatory or course, but can be useful)
%{optflags} are not used in make.
Patch file should be prefixed with the package name.
Comment 2 Rahul Sundaram 2007-10-01 02:18:26 EDT
Thanks for the review. Updated as per review

Comment 3 Parag AN(पराग) 2007-10-03 03:16:22 EDT
Change Release line to
Release: 2%{?dist}
and Change defattr line to
%defattr(-, root, root, -)

Comment 4 Parag AN(पराग) 2007-10-03 04:32:26 EDT
and rpmlint gave me
aget.i386: E: description-line-too-long Aget is a multi-threaded download
accelerator like Flashget. It supports HTTP downloads and can be run from the
===>Your description lines must not exceed 79 characters. If a line is exceeding
this number, cut it to fit in two lines.
Comment 6 Parag AN(पराग) 2007-10-03 07:43:07 EDT
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
1d32390f5ea2ddd82dfbb1794cdfa92f  aget-0.4.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

Comment 7 Rahul Sundaram 2007-10-03 09:29:52 EDT
New Package CVS Request
Package Name: aget
Short Description: Console download accelerator
Owners: sundaram
Branches: F-7 EL-4 EL-5
Cvsextras Commits: yes
Comment 8 Parag AN(पराग) 2007-10-03 11:04:44 EDT
  Learn first how to use Bugzilla, at least how and when to set/reset flags. You
reverted fedora-review+ flag set by me.
Thanks mtasaka for correcting them.
Comment 9 Rahul Sundaram 2007-10-03 11:45:56 EDT
I set the flag on fedora-review instead of fedora-cvs accidently. Confusing docs
don't help either. 
Comment 10 Kevin Fenzi 2007-10-03 22:45:18 EDT
cvs done.

Note You need to log in before you can comment on or make changes to this bug.