Bug 318611

Summary: Inconsistency between binary prefix v.s. symlink name
Product: [Fedora] Fedora Reporter: Mamoru TASAKA <mtasaka>
Component: rss-glxAssignee: Nils Philippsen <nphilipp>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-10-04 22:04:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Mamoru TASAKA 2007-10-04 15:59:34 UTC
Description of problem:
It seems that with bug 250180 now the real binary of rss-glx
hacks have rss-glx prefix, and 
%_datadir/xscreensaver/hacks.conf.d/rss-glx.conf reflects those
change.

However, hacks' symlinks in rss-glx-xscreensaver under
%_libexecdir/xscreensaver does not have rss-glx prefix, which is
inconsistent.

Version-Release number of selected component (if applicable):
rss-glx-0.8.1.p-13.fc8
rss-glx-xscreensaver-0.8.1.p-13.fc8


Additional info:
From xscreensaver driver/subproc.c:
----------------------------------------------------------------
  1113  void
  1114  hack_environment (saver_info *si)
  1115  {
  1116  #if defined(HAVE_PUTENV) && defined(DEFAULT_PATH_PREFIX)
  1117    static const char *def_path = DEFAULT_PATH_PREFIX;
  1118    if (def_path && *def_path)
  1119      {
  1120        const char *opath = getenv("PATH");
  1121        char *npath = (char *) malloc(strlen(def_path) + strlen(opath) + 20);
  1122        strcpy (npath, "PATH=");
  1123        strcat (npath, def_path);
  1124        strcat (npath, ":");
  1125        strcat (npath, opath);
  1126  
  1127        if (putenv (npath))
  1128          abort ();
  1129  
  1130        /* don't free (npath) -- some implementations of putenv (BSD 4.4,
  1131           glibc 2.0) copy the argument, but some (libc4,5, glibc 2.1.2)
  1132           do not.  So we must leak it (and/or the previous setting). Yay.
  1133         */
  1134      }
  1135  #endif /* HAVE_PUTENV && DEFAULT_PATH_PREFIX */
  1136  }
----------------------------------------------------------------

So xscreensaver first seeks for hacks under %_libexecdir/xscreensaver,
then under default path. So currently all rss-glx symlinks under
%_libexecdir/xscreensaver are all simply ignored and
xscreensaver finds rss-glx hacks under %_bindir directly.

Comment 1 Nils Philippsen 2007-10-04 22:04:22 UTC
should be fixed in rss-glx-0.8.1.p-14.fc8