Bug 328261
| Summary: | Review Request: netembryo - Network abstraction library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dominik 'Rathann' Mierzejewski <dominik> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-11-08 20:05:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 328291 | ||
|
Description
Dominik 'Rathann' Mierzejewski
2007-10-11 19:57:08 UTC
preliminary review -> rpmlint gave me netembryo.i386: W: incoherent-version-in-changelog 0.0.4-0.1 0.0.4-0.1.20071011git The last entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. netembryo-devel.i386: W: summary-not-capitalized netembryo development library and headers Summary doesn't begin with a capital letter. mock build went fine for i386 Also, good to add test directory to %doc of -devel Do you want to use disttag? Its not mandatory but good to use them in SPEC. http://rathann.fedorapeople.org/review/netembryo.spec Updated spec. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM But not for RPM. netembryo.i386: W: incoherent-version-in-changelog 0.0.4-0.2.20071011 0.0.4-0.2.20071011git.fc8 ==> you can take care this at time of importing package in CVS. + source files match upstream. ba732800e20247a660e14eca5386113c netembryo-20071011git.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + netembryo.pc files are present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + ldconfig scriptlets are used. + netembryo-0.0.4-0.2.20071011git.fc8 package -> Provides: libnetembryo.so.0 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libnetembryo.so.0 libsctp.so.1 rtld(GNU_HASH) + netembryo-devel-0.0.4-0.2.20071011git.fc8 package -> Requires: libnetembryo.so.0 netembryo = 0.0.4-0.2.20071011git pkgconfig + Not a GUI app. APPROVED. Thanks for the review! New Package CVS Request ======================= Package Name: netembryo Short Description: Network abstraction library Owners: rathann Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes cvs done. Built for devel. |