Spec URL: http://rathann.fedorapeople.org/review/libnemesi.spec SRPM URL: http://rathann.fedorapeople.org/review/libnemesi-0.6.2-0.1.20071011git.src.rpm Description: Libnemesi let you add multimedia streaming playback in your applications in a quick and straightforward way. This software, derived from the experience matured with NeMeSi is fully compliant with IETF's standards for real-time streaming of multimedia contents over Internet. libnemesi implements RTSP – Real-Time Streaming Protocol (RFC2326) and RTP/RTCP – Real-Time Transport Protocol/RTP Control Protocol (RFC3550) supporting the RTP Profile for Audio and Video Conferences with Minimal Control (RFC3551).
mock build went fine. some warnings I got from rpmlint are => libnemesi.i386: W: incoherent-version-in-changelog 0.6.2-0.1 0.6.2-0.1.20071011git The last entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. libnemesi-devel.i386: W: summary-not-capitalized nemesi development library and headers Summary doesn't begin with a capital letter.
Also, Good to add examples to %doc of -devel package.
Do you want to use disttag? Its not mandatory.
I'll fix the changelog. Examples contain only code and the resulting binaries are installed in %{_bindir}. I'll add the disttag, too.
can you please give updates SPEC so that I will finish this review?
http://rathann.fedorapeople.org/review/libnemesi.spec Updated spec.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM but NOT for RPM. libnemesi.i386: W: incoherent-version-in-changelog 0.6.2-0.2.20071011 0.6.2-0.2.20071011git.fc8 ==> can be solved at time of CVS import. + source files match upstream. 2bedb3f40f0afc2c7cec49bb8b132732 libnemesi-20071011git.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + libnemesi.pc files are present. + -devel and -tools subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + ldconfig scriptlets are used. + libnemesi-0.6.2-0.2.20071011git package -> Provides: libnemesi.so.0 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GCC_3.3.1) libm.so.6 libnemesi.so.0 libnetembryo.so.0 libpthread.so.0 libpthread.so.0(GLIBC_2.0) libpthread.so.0(GLIBC_2.1) libpthread.so.0(GLIBC_2.3.2) libsctp.so.1 rtld(GNU_HASH) + libnemesi-devel-0.6.2-0.2.20071011git package -> Requires: libnemesi = 0.6.2-0.2.20071011git libnemesi.so.0 pkgconfig + libnemesi-tools-0.6.2-0.2.20071011git package -> Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libm.so.6 libnemesi.so.0 libnetembryo.so.0 libpthread.so.0 libpthread.so.0(GLIBC_2.0) libsctp.so.1 rtld(GNU_HASH) + Not a GUI app. APPROVED.
Thanks for the review! New Package CVS Request ======================= Package Name: libnemesi Short Description: RTSP/RTP client library Owners: rathann Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Built for devel.