Bug 344711
| Summary: | kde-settings: Use fedora-bookmarks in konqueror | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sebastian Vahl <fedora> |
| Component: | kde-settings | Assignee: | Than Ngo <than> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | kevin, rdieter |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-02-15 12:47:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 421891 | ||
| Attachments: | |||
|
Description
Sebastian Vahl
2007-10-21 20:23:38 UTC
Definitely doable, but better placed in kde-settings somewhere... reassigning. Created attachment 235661 [details]
Suse startscript which copies bookmarks.xml to the users homedir
I tried to figure out how to integrate this and so looked into other
distributions: Suse has a folder in the bookmarks toolbar.
It seems that they copy the bookmarks.xml (if it don't exist yet) from
/opt/kde3/share/config/SuSE/default/bookmark.xml (which seems to be the same as
our kde-settings) to the users ~/.kde/share/apps/konqueror/toolbar
I've attached their script so that you could have a look into it.
I think coping the bookmarks.xml in /usr/bin/startkde if it is not existing in the users homedir would be the best. I've attached a patch for startkde with a short section of doing so. (I'm not sure where is the best place in startkde, I've picked on in the middle). The second attachment is an imported bookmarks.xml from fedora-bookmarks-8-1. I've imported the bookmarks by hand and used "show folder in toolbar" to display them in konqueror's bookmarks toolbar. The bookmarks.xml should be placed in /usr/share/kde-settings/kde-profile/default/share/apps/konqueror/bookmarks.xml (and also included there in kde-settings' tarball). Created attachment 239661 [details]
patch against startkde
Created attachment 239671 [details]
converted bookmarks.xml for usage in konqueror
If we want to implement this at session start, dropping a script into /etc/kde/env makes more sense than patching startkde, imo. Ok. That would also be an option. Created attachment 289937 [details] /etc/kde/env/fedora-bookmarks.sh (In reply to comment #6) > If we want to implement this at session start, dropping a script into > /etc/kde/env makes more sense than patching startkde, imo. ok. here it is. Created attachment 289938 [details] Patch against kde-settings.spec to inlcude bookmarks Additional sources are bookmarks.xml from comment #5 and fedora-bookmarks.sh from comment #8. Seems to work in kde4's konqueror. Only some (fav)icons are missing. Created attachment 294932 [details]
converted bookmarks.xml for usage in konqueror (favicons updated)
I really like to get this in KDE for F9. Any chance for that? Or any comments
on the given solution or a better one?
Sebastian, it looks sane to me. I will commit it into CVS and build it. Thanks |