Red Hat Bugzilla – Bug 344711
kde-settings: Use fedora-bookmarks in konqueror
Last modified: 2008-02-15 07:47:14 EST
Description of problem:
I think we should use the bookmarks from fedora-bookmarks also in konqueror's
web-browsing-mode. For this the bookmarks toolbar should be used in standard
view of the web-browsing mode.
I don't know what would be the best steps to do this:
- create a dependency from kdebase to fedora-bookmarks and
include /usr/share/bookmarks/default-bookmarks.html as a folder (if possible)
- import a snapshot from fedora-bookmarks before the new release of fedora.
Definitely doable, but better placed in kde-settings somewhere... reassigning.
Created attachment 235661 [details]
Suse startscript which copies bookmarks.xml to the users homedir
I tried to figure out how to integrate this and so looked into other
distributions: Suse has a folder in the bookmarks toolbar.
It seems that they copy the bookmarks.xml (if it don't exist yet) from
/opt/kde3/share/config/SuSE/default/bookmark.xml (which seems to be the same as
our kde-settings) to the users ~/.kde/share/apps/konqueror/toolbar
I've attached their script so that you could have a look into it.
I think coping the bookmarks.xml in /usr/bin/startkde if it is not existing in
the users homedir would be the best. I've attached a patch for startkde with a
short section of doing so. (I'm not sure where is the best place in startkde,
I've picked on in the middle).
The second attachment is an imported bookmarks.xml from fedora-bookmarks-8-1.
I've imported the bookmarks by hand and used "show folder in toolbar" to
display them in konqueror's bookmarks toolbar.
The bookmarks.xml should be placed
(and also included there in kde-settings' tarball).
Created attachment 239661 [details]
patch against startkde
Created attachment 239671 [details]
converted bookmarks.xml for usage in konqueror
If we want to implement this at session start, dropping a script into
/etc/kde/env makes more sense than patching startkde, imo.
Ok. That would also be an option.
Created attachment 289937 [details]
(In reply to comment #6)
> If we want to implement this at session start, dropping a script into
> /etc/kde/env makes more sense than patching startkde, imo.
ok. here it is.
Created attachment 289938 [details]
Patch against kde-settings.spec to inlcude bookmarks
Additional sources are bookmarks.xml from comment #5 and fedora-bookmarks.sh
from comment #8.
Seems to work in kde4's konqueror. Only some (fav)icons are missing.
Created attachment 294932 [details]
converted bookmarks.xml for usage in konqueror (favicons updated)
I really like to get this in KDE for F9. Any chance for that? Or any comments
on the given solution or a better one?
Sebastian, it looks sane to me. I will commit it into CVS and build it.