Bug 345261

Summary:	Review Request: libmikmod - A MOD music file player library
Product:	[Fedora] Fedora	Reporter:	Jindrich Novy <jnovy>
Component:	Package Review	Assignee:	Lubomir Rintel <lkundrak>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora, fedora-package-review, notting, pbrobinson, pknirsch
Target Milestone:	---	Flags:	lkundrak: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-10-24 10:31:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jindrich Novy 2007-10-22 14:30:05 UTC

Spec URL: http://people.redhat.com/jnovy/files/libmikmod/libmikmod.spec
SRPM URL: http://people.redhat.com/jnovy/files/libmikmod/libmikmod-3.1.11-1.fc8.src.rpm
Description:

mikmod comes with a libmikmod library, which is installed into a buildroot and mikmod is linked against it. This causes there are direct links to buildroot in the mikmod executable what prevents mikmod to be successfuly build -> rhbz#339881. 

General solution is to package libmikmod separately, so that mikmod could BR it and also other users could use libmikmod as soon as it's packaged separately.

Comment 1 Lubomir Kundrak 2007-10-23 13:51:40 UTC

Please correct the %description to say that this is actually a library, not the
player. Maybe also the mikmod description should be adjusted not to mention the
obsolete OSS (I see the library has patch for ESound output).

You don't pass %{_smp_flags} to make. Please either comment why are concurrent
builds not feasible, or add the flags.

Comment 2 Lubomir Kundrak 2007-10-23 13:58:54 UTC

rpmlint:

$ rpmlint
/var/lib/mock/fedora-development-i386/result/libmikmod-3.1.11-1.fc8.i386.rpm 
$ rpmlint
/var/lib/mock/fedora-development-i386/result/libmikmod-3.1.11-1.fc8.src.rpm 
$ rpmlint /var/lib/mock/fedora-development-i386/result/libmikmod-de
libmikmod-debuginfo-3.1.11-1.fc8.i386.rpm  libmikmod-devel-3.1.11-1.fc8.i386.rpm
     
$ rpmlint
/var/lib/mock/fedora-development-i386/result/libmikmod-devel-3.1.11-1.fc8.i386.rpm 
libmikmod-devel.i386: W: spurious-executable-perm /usr/lib/libmikmod.a
libmikmod-devel.i386: W: summary-ended-with-dot Header files and documentation
for compiling mikmod applications.
$ rpmlint
/var/lib/mock/fedora-development-i386/result/libmikmod-debuginfo-3.1.11-1.fc8.i386.rpm

$

Please deal with those

Comment 3 Jindrich Novy 2007-10-23 15:20:08 UTC

Updated, please check again.

Comment 4 Lubomir Kundrak 2007-10-23 15:36:35 UTC

Aright, outstanding issues have been solved, I see no other problems, and so do
qa script and rpmlint. Therefore, the package is

APPROVED

Comment 5 Jindrich Novy 2007-10-23 15:45:46 UTC

New Package CVS Request
=======================
Package Name: libmikmod
Short Description: A MOD music file player library
Owners: jnovy
Branches: 
InitialCC: 
Cvsextras Commits: yes

Comment 6 Toshio Ernie Kuratomi 2007-10-23 17:55:28 UTC

cvs done.

Comment 7 Jindrich Novy 2007-10-24 10:31:17 UTC

Imported. Thanks!

Comment 8 Peter Robinson 2010-06-10 20:11:56 UTC

Package Change Request
======================
Package Name: libmikmod
New Branches: EL-6
Owners: pbrobinson sdz

Comment 9 Kevin Fenzi 2010-06-11 04:32:58 UTC

Have you checked with jnovy to see if he would like to maintain this in EPEL?

Comment 10 Jindrich Novy 2010-07-09 06:16:25 UTC

I've been just contacted because of the mikmod branching request because of SDL_mixer dependency in EPEL-6 which makes sense.

Kevin, could you please process the CVS request in comment #8?

Thanks!

Comment 11 Kevin Fenzi 2010-07-09 18:09:07 UTC

Happy to do so. Thanks for the info. 

CVS done (by process-cvs-requests.py).