Spec URL: http://people.redhat.com/jnovy/files/libmikmod/libmikmod.spec SRPM URL: http://people.redhat.com/jnovy/files/libmikmod/libmikmod-3.1.11-1.fc8.src.rpm Description: mikmod comes with a libmikmod library, which is installed into a buildroot and mikmod is linked against it. This causes there are direct links to buildroot in the mikmod executable what prevents mikmod to be successfuly build -> rhbz#339881. General solution is to package libmikmod separately, so that mikmod could BR it and also other users could use libmikmod as soon as it's packaged separately.
Please correct the %description to say that this is actually a library, not the player. Maybe also the mikmod description should be adjusted not to mention the obsolete OSS (I see the library has patch for ESound output). You don't pass %{_smp_flags} to make. Please either comment why are concurrent builds not feasible, or add the flags.
rpmlint: $ rpmlint /var/lib/mock/fedora-development-i386/result/libmikmod-3.1.11-1.fc8.i386.rpm $ rpmlint /var/lib/mock/fedora-development-i386/result/libmikmod-3.1.11-1.fc8.src.rpm $ rpmlint /var/lib/mock/fedora-development-i386/result/libmikmod-de libmikmod-debuginfo-3.1.11-1.fc8.i386.rpm libmikmod-devel-3.1.11-1.fc8.i386.rpm $ rpmlint /var/lib/mock/fedora-development-i386/result/libmikmod-devel-3.1.11-1.fc8.i386.rpm libmikmod-devel.i386: W: spurious-executable-perm /usr/lib/libmikmod.a libmikmod-devel.i386: W: summary-ended-with-dot Header files and documentation for compiling mikmod applications. $ rpmlint /var/lib/mock/fedora-development-i386/result/libmikmod-debuginfo-3.1.11-1.fc8.i386.rpm $ Please deal with those
Updated, please check again.
Aright, outstanding issues have been solved, I see no other problems, and so do qa script and rpmlint. Therefore, the package is APPROVED
New Package CVS Request ======================= Package Name: libmikmod Short Description: A MOD music file player library Owners: jnovy Branches: InitialCC: Cvsextras Commits: yes
cvs done.
Imported. Thanks!
Package Change Request ====================== Package Name: libmikmod New Branches: EL-6 Owners: pbrobinson sdz
Have you checked with jnovy to see if he would like to maintain this in EPEL?
I've been just contacted because of the mikmod branching request because of SDL_mixer dependency in EPEL-6 which makes sense. Kevin, could you please process the CVS request in comment #8? Thanks!
Happy to do so. Thanks for the info. CVS done (by process-cvs-requests.py).