Bug 346161
| Summary: | Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video driver | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Chauvet (kwizart) <kwizart> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-03-06 20:11:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 346171 | ||
| Bug Blocks: | |||
|
Description
Nicolas Chauvet (kwizart)
2007-10-23 00:24:28 UTC
Spec URL: http://kwizart.free.fr/fedora/7/testing/xorg-x11-drv-ivtv/xorg-x11-drv-ivtv.spec koji task: http://koji.fedoraproject.org/koji/taskinfo?taskID=206411 This is a basic xorg driver; nothing fancy. rpmlint is silent and everything looks good. I have the firmware in a local repo so that this will install properly for me, but I don't have the hardware to test this on. You might want to flesh out the description just a little bit if possible. Specifically, it would be nice to know which boards are supported. It looks like it only works with the PVR350; I'm not sure that the other boards have a framebuffer or even do any output. * source files match upstream: e98a2ed67fea25ab7f94eecb5a53a2d3a3c42de93557d77d774fa18d311c807a xf86-video-ivtv-1.0.0.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. ? description is OK (might be nice to include a little more info) * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: ivtv_drv.so()(64bit) xorg-x11-drv-ivtv = 1.0.0-1.fc8 = ivtv-firmware xorg-x11-server-Xorg >= 1.3.0.0-6 * %check is not present; I've no way to test this package. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED New Package CVS Request ======================= Package Name: xorg-x11-drv-ivtv Short Description: Xorg X11 ivtv video driver Owners: kwizart Branches: F-8 F-7 InitialCC: <empty> Commits by cvsextras: yes cvs done. Ok libpciaccess and another patch fixed upstream. Closing to next release |