Bug 350781
Summary: | Review Request: libvoikko - A library for spellcheckers and hyphenators | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ville-Pekka Vainio <vpvainio> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-11-14 11:19:42 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 346121, 349191 | ||
Bug Blocks: |
Description
Ville-Pekka Vainio
2007-10-24 16:56:06 UTC
When the rebuild of malaga-suomi-voikko is done for F-9, I will check this. Some quick comment: * Rebuild fails at least on i386. http://koji.fedoraproject.org/koji/taskinfo?taskID=224229 It seems at least malaga-devel is missing from BR. * malaga-suomi-voikko already requires malaga. * Please remove static archive. New SPEC: http://vpv.fedorapeople.org/packages/libvoikko.spec New SRPM: http://vpv.fedorapeople.org/packages/libvoikko-1.5-0.2.fc7.src.rpm I believe I fixed all those issues you pointed out. I also built it in koji as a scratch build, which succeeded. For 1.5-0.2: * Requires for libvoikko-devel - Would you explain why libvoikko-devel should have "Requires: malaga-devel"? It seems that no header files in libvoikko-devel requires header files in malaga-devel. * Timestamps - Adding 'INSTALL="install -p"' option to "make install" will save timestamps on man files and header files. (This method usually works for most recent Makefiles). New Spec: http://vpv.fedorapeople.org/packages/libvoikko.spec New SRPM: http://vpv.fedorapeople.org/packages/libvoikko-1.5-0.3.fc7.src.rpm I removed Requires: malaga-devel from libvoikko-devel, it really wasn't needed. I also added INSTALL="install -p" to make install as you requested. Okay. ----------------------------------------------------------------- This package (libvoikko) is APPROVED by me ----------------------------------------------------------------- New Package CVS Request ======================= Package Name: libvoikko Short Description: A library for spellcheckers and hyphenators Owners: vpv Branches: F-7 F-8 Cvsextras Commits: yes Mamoru Tasaka, thanks again for your review and help. I'm planning to package tmispell-voikko and openoffice.org-voikko later, those would enable using voikko in some KDE and GNOME applications and OO.o. They're both a bit difficult, since tmispell-voikko replaces a possibly installed "original" tmispell and OO.o updates with the voikko component can apparently be a bit problematic. I'll probably send an email to fedora-devel when I have time to start packaging those. cvs done. Please close this bug when rebuild and request on koji is done. Sorry about leaving this open, I just forgot to close it. Libvoikko has been built in Rawhide, I haven't yet requested for the dependencies to be added to F-7 and F-8 buildroots, I'll probably do that soon. |