Red Hat Bugzilla – Bug 349191
Review Request: malaga-suomi-voikko - A description of Finnish morphology written in Malaga (Voikko edition)
Last modified: 2012-09-18 10:28:53 EDT
Spec URL: http://vpv.fedorapeople.org/packages/malaga-suomi-voikko.spec SRPM URL: http://vpv.fedorapeople.org/packages/malaga-suomi-voikko-0.7.6-0.1.fc7.src.rpm Description: A description of Finnish morphology written in Malaga. This version is modified to support the Voikko spellchecker/hyphenator and is not compatible with the Sukija text indexer. I've named the package malaga-suomi-voikko, because it extends Malaga (see Bug #346121) with Finnish and it is a modified version to support the F/OSS Finnish spell checker Voikko, which I intend to package also. This way malaga-suomi (without Voikko support) could be packaged separately if needed. Rpmlint outputs these errors: malaga-suomi-voikko.i386: E: no-binary malaga-suomi-voikko.i386: E: only-non-binary-in-usr-lib I have explained these in the comments of the spec file, copied here as well: Files differ on big-endian and small-endian archs, and they have different names (*_l vs *_b). This is the reason we use %{_libdir} instead of %{_datadir} and won't noarch the package. This is exactly what the Voikko developers asked me to do, they think that using /usr/share would be wrong, because of the issue mentioned above.
This is just a initial comment: - malaga requires libmalaga, so "(Build)Requires: libmalaga" is actally not needed. - For %files entry ------------------------------------------------------------ %files %{_libdir}/voikko %{_libdir}/voikko/voikko-fi_FI*_l %{_libdir}/voikko/voikko-fi_FI.pro ------------------------------------------------------------- The entry "%_libdir/voikko" (which is a directory) means the directory %_libdir/voikko itself and all files/directories/etc under this directory, so the following two entries are not needed. - Rebuild fails on ppc and ppc64. For ppc: http://koji.fedoraproject.org/koji/taskinfo?taskID=222539 For ppc64: ttp://koji.fedoraproject.org/koji/taskinfo?taskID=222476
New SPEC: http://vpv.fedorapeople.org/packages/malaga-suomi-voikko.spec New SRPM: http://vpv.fedorapeople.org/packages/malaga-suomi-voikko-0.7.6-0.2.fc7.src.rpm (In reply to comment #1) > - malaga requires libmalaga, so "(Build)Requires: libmalaga" is actally > not needed. Fixed. > The entry "%_libdir/voikko" (which is a directory) means the > directory %_libdir/voikko itself and all files/directories/etc > under this directory, so the following two entries are not needed. Fixed, this also fixes the ppc and ppc64 build failures, I tested the new SRPM myself in koji.
---------------------------------------------------------------- This package (malaga-suomi-voikko) is APPROVED by me ----------------------------------------------------------------
New Package CVS Request ======================= Package Name: malaga-suomi-voikko Short Description: A description of Finnish morphology written in Malaga (Voikko edition) Owners: vpv Branches: F-7 F-8 Cvsextras Commits: yes
cvs done.
Package built for devel, see http://koji.fedoraproject.org/koji/taskinfo?taskID=223475 I also tried to build it for F-7 and F-8, which didn't succeed, because they don't have Malaga yet. I assume I need to wait for the updates to be pushed before building? In any case, I'm closing this bug.
* you can ask rel-eng team to add malaga to buildroot so that you can rebuild this package on F-7 or F-8. When mailing to rel-eng team, please show them the EVR (epoch-version-release) of malaga to be added to buildroot.