Bug 351711
| Summary: | Review Request: perl-Inline-Files - Allows for multiple inline files in a single perl file | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robin Norwood <robin.norwood> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.62-2 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-04 05:33:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Robin Norwood
2007-10-25 04:07:14 UTC
The permissions inside of the tarball are broken. Please change these permissions in %prep. All the chmod's in %install are a side-effect of these broken permissions and probably can be removed. Good to change permissions in %prep Robin, Can you please provide updates here? New release with fixed permissions: http://people.redhat.com/rnorwood/rpms/perl-Inline-Files.spec http://people.redhat.com/rnorwood/rpms/perl-Inline-Files-0.62-2.fc9.src.rpm Thanks. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 1beb4548be878a28cafb379945c402b8 Inline-Files-0.62.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00init.......ok t/01basics.....ok t/02write......ok t/03nowrite....ok t/04create.....ok t/05seek.......ok t/06backup.....ok t/07hash.......ok All tests successful. Files=8, Tests=67, 3 wallclock secs ( 0.99 cusr + 0.09 csys = 1.08 CPU) + Package perl-Inline-Files-0.62-2.fc9 -> Provides: perl(Inline::Files) = 0.62 perl(Inline::Files::Data) perl(Inline::Files::Virtual) = 0.53 Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Cwd) perl(Filter::Util::Call) perl(Inline::Files::Virtual) perl(strict) perl(vars) APPROVED. New Package CVS Request ======================= Package Name: perl-Inline-Files Short Description: Allows for multiple inline files in a single perl file Owners: rnorwood Branches: devel InitialCC: fedora-perl-devel-list Cvsextras Commits: yes cvs done. Needed in EPEL for perl-Inline Package Change Request ====================== Package Name: perl-Inline-Files New Branches: EL-4 EL-5 cvs done. Built for EL-4 and EL-5 |