Bug 352841
Summary: | GFS2: Evaluate and implement missing gfs2_tool features | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 5 | Reporter: | Robert Peterson <rpeterso> | ||||||
Component: | gfs2-utils | Assignee: | Chris Feist <cfeist> | ||||||
Status: | CLOSED ERRATA | QA Contact: | GFS Bugs <gfs-bugs> | ||||||
Severity: | low | Docs Contact: | |||||||
Priority: | low | ||||||||
Version: | 5.1 | CC: | teigland | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | RHBA-2008-0350 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2008-05-21 17:20:22 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Robert Peterson
2007-10-25 17:35:25 UTC
I've gone through the options that are missing from gfs2_tool and here is my analysis. The following is a list of "missing" options and where we stand: 1. Option: flush Description: Sync out dirty data for a file and drop its glock. Status: There's no good way to implement this today, except open and fsync. 2. Option: stat Description: Print gfs2_dinode for a file. Status: There's no good way to implement this today. The gfs2_edit command can do this, give the inode address. Right now you can't give it a path. 3. Option: getsb Description: Print out the gfs2 superblock Status: There is a command equivalent in gfs2_edit: gfs2_tool -p sb so I don't see the need to implement this. 4. Option: jindex Description: Print out the journal index Status: There is a command equivalent in gfs2_edit: gfs2_tool -p jindex so I don't see the need to implement this. 5. Option: rindex Description: Print out the resource group index file Status: There is a command equivalent in gfs2_edit: gfs2_tool -p rindex so I don't see the need to implement this. 6. Option: quota Description: Print out the quota file details Status: There is a command equivalent in gfs2_edit: gfs2_tool -p quota so I don't see the need to implement this. 7. Option: layout Description: Print out the layout of a file Status: There is a separate bugzilla record to implement this feature. 8. Option: df Description: Print out a bunch of information about the file system Status: Some customer might be using this. It might be nice to implement this. Conclusion: IMHO, the only missing option we should consider implementing at this time is the "df" command. Created attachment 257481 [details]
Patch to add the "df" functionality
This is my initial attempt to add the "df" function back to gfs2_tool.
Created attachment 258441 [details]
Better patch
This version of the patch is the one I'm planning to commit.
It has a few small improvements, such as the "df" help printing
in the alphabetically correct section of the gfs2_tool -h output.
I also eliminated some cruft from the previous patch.
The code was tested on system roth-01 including the man page, -h option, and new df options for both single and multiple file systems (both HEAD and RHEL5 versions). The code was committed to the HEAD and RHEL5 branches of CVS. I'm therefore changing the status to modified. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2008-0350.html |