Bug 365131

Summary: Review Request: ruby-imagesize - Measure image size code by Pure Ruby
Product: [Fedora] Fedora Reporter: Mamoru TASAKA <mtasaka>
Component: Package ReviewAssignee: Nicolas Chauvet (kwizart) <kwizart>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: kwizart: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-11-17 11:25:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Mamoru TASAKA 2007-11-03 11:31:27 UTC
Spec URL: http://mtasaka.fedorapeople.org/Review_request/ruby-imagesize/ruby-imagesize.spec
SRPM URL: http://mtasaka.fedorapeople.org/Review_request/ruby-imagesize/ruby-imagesize-0.1.1-1.fc8.src.rpm
Description: 
Imagefile measures image (GIF, PNG, JPEG ,,, etc) size code 
by Pure Ruby ["PCX", "PSD", "XPM", "TIFF", "XBM", "PGM", 
"PBM", "PPM", "BMP", "JPEG", "PNG", "GIF", "SWF"]

Koji rebuild:
for dist-f8-updates-candidate:
http://koji.fedoraproject.org/koji/taskinfo?taskID=225206
for dist-fc7-updates-candidate:
http://koji.fedoraproject.org/koji/taskinfo?taskID=225208

Comment 1 Nicolas Chauvet (kwizart) 2007-11-10 01:14:11 UTC
Review in progress...

Comment 2 Nicolas Chauvet (kwizart) 2007-11-10 02:14:35 UTC
There is two tests that failed
I wonder if it is because there is no ppm.ppm image ?!


Comment 3 Mamoru TASAKA 2007-11-10 07:36:04 UTC
Well, I guess ppm.ppm test is surely disabled as

-----------------------------------------------------
%check
%{__sed} -i.ppm \
	-e "s|'ppm.ppm', ||" \
	-e '/PPM/d' \
	test/test_image_size.rb
ruby setup.rb test
-----------------------------------------------------
Abd koji build is successful.
http://koji.fedoraproject.org/koji/taskinfo?taskID=234171

Comment 4 Nicolas Chauvet (kwizart) 2007-11-16 13:23:30 UTC
Sorry for the long reply...
The package by itself seems good but i'm not abble to test at runtime as i don't
know ruby ... (Iv'e found a Simple Example - but i don't even knwo how to uses
it...)

---------------------------------------------------------------

    This package (ruby-imagesize) is APPROVED by me

---------------------------------------------------------------

Comment 5 Mamoru TASAKA 2007-11-16 14:35:42 UTC
Thanks!

---------------------------------------------------------------
New Package CVS Request
=======================
Package Name:        ruby-imagesize
Short Description:   Measure image size code by Pure Ruby
Owners:              mtasaka
Branches:            F-7 F-8
Cvsextras Commits:   yes

Comment 6 Kevin Fenzi 2007-11-16 17:12:05 UTC
cvs done.

Comment 7 Mamoru TASAKA 2007-11-17 11:25:32 UTC
Rebuilt on devel, F-8, F-7, requested on bodhi, closing.

Thank you for your review!