Bug 365131
Summary: | Review Request: ruby-imagesize - Measure image size code by Pure Ruby | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mamoru TASAKA <mtasaka> |
Component: | Package Review | Assignee: | Nicolas Chauvet (kwizart) <kwizart> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | kwizart:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-11-17 11:25:32 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Mamoru TASAKA
2007-11-03 11:31:27 UTC
Review in progress... There is two tests that failed I wonder if it is because there is no ppm.ppm image ?! Well, I guess ppm.ppm test is surely disabled as ----------------------------------------------------- %check %{__sed} -i.ppm \ -e "s|'ppm.ppm', ||" \ -e '/PPM/d' \ test/test_image_size.rb ruby setup.rb test ----------------------------------------------------- Abd koji build is successful. http://koji.fedoraproject.org/koji/taskinfo?taskID=234171 Sorry for the long reply... The package by itself seems good but i'm not abble to test at runtime as i don't know ruby ... (Iv'e found a Simple Example - but i don't even knwo how to uses it...) --------------------------------------------------------------- This package (ruby-imagesize) is APPROVED by me --------------------------------------------------------------- Thanks! --------------------------------------------------------------- New Package CVS Request ======================= Package Name: ruby-imagesize Short Description: Measure image size code by Pure Ruby Owners: mtasaka Branches: F-7 F-8 Cvsextras Commits: yes cvs done. Rebuilt on devel, F-8, F-7, requested on bodhi, closing. Thank you for your review! |