Spec URL: http://mtasaka.fedorapeople.org/Review_request/ruby-imagesize/ruby-imagesize.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/ruby-imagesize/ruby-imagesize-0.1.1-1.fc8.src.rpm Description: Imagefile measures image (GIF, PNG, JPEG ,,, etc) size code by Pure Ruby ["PCX", "PSD", "XPM", "TIFF", "XBM", "PGM", "PBM", "PPM", "BMP", "JPEG", "PNG", "GIF", "SWF"] Koji rebuild: for dist-f8-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=225206 for dist-fc7-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=225208
Review in progress...
There is two tests that failed I wonder if it is because there is no ppm.ppm image ?!
Well, I guess ppm.ppm test is surely disabled as ----------------------------------------------------- %check %{__sed} -i.ppm \ -e "s|'ppm.ppm', ||" \ -e '/PPM/d' \ test/test_image_size.rb ruby setup.rb test ----------------------------------------------------- Abd koji build is successful. http://koji.fedoraproject.org/koji/taskinfo?taskID=234171
Sorry for the long reply... The package by itself seems good but i'm not abble to test at runtime as i don't know ruby ... (Iv'e found a Simple Example - but i don't even knwo how to uses it...) --------------------------------------------------------------- This package (ruby-imagesize) is APPROVED by me ---------------------------------------------------------------
Thanks! --------------------------------------------------------------- New Package CVS Request ======================= Package Name: ruby-imagesize Short Description: Measure image size code by Pure Ruby Owners: mtasaka Branches: F-7 F-8 Cvsextras Commits: yes
cvs done.
Rebuilt on devel, F-8, F-7, requested on bodhi, closing. Thank you for your review!