Bug 371461

Summary:	Review Request: fuseiso - FUSE support for ISO filesystem images
Product:	[Fedora] Fedora	Reporter:	Tom "spot" Callaway <tcallawa>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, lemenkov, notting
Target Milestone:	---	Flags:	panemade: fedora-review+ tcallawa: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-11-20 22:23:49 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tom "spot" Callaway 2007-11-08 16:42:32 UTC

Spec URL: http://www.auroralinux.org/people/spot/review/new/fuseiso.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/fuseiso-20070708-1.fc8.src.rpm

Description: 
Mount ISO filesystem images as a non-root user. Currently supports
plain ISO9660 Level 1 and 2, Rock Ridge, Joliet, zisofs. Supported image
types: ISO, BIN (single track only), NRG, MDF, IMG (CCD).

Comment 1 Parag AN(पराग) 2007-11-13 06:53:02 UTC

1)how about changing source URL as
http://ubiz.ru/dm/%{name}-%{version}.tar.bz2

2) Good to have defattr usage as
%defattr(-,root,root,-)

3) missing BR: zlib-devel

Comment 2 Tom "spot" Callaway 2007-11-14 14:45:56 UTC

New Spec URL: http://www.auroralinux.org/people/spot/review/new/fuseiso.spec
New SRPM URL:
http://www.auroralinux.org/people/spot/review/new/fuseiso-20070708-2.fc9.src.rpm

All three items fixed (although #2 is a bit pointless, since - in the last
position is the same as keeping it blank).

Comment 3 Parag AN(पराग) 2007-11-15 04:17:22 UTC

Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
4bb50412b6d01f337565e28afddca3a5  fuseiso-20070708.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package fuseiso-20070708-2.fc8 ->
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3.4)
libc.so.6(GLIBC_2.4) libdl.so.2 libfuse.so.2 libfuse.so.2(FUSE_2.5)
libglib-2.0.so.0 libpthread.so.0 libpthread.so.0(GLIBC_2.0)
libpthread.so.0(GLIBC_2.2) librt.so.1 libz.so.1 rtld(GNU_HASH)
+ Not a GUI App.
APPROVED.

Comment 4 Tom "spot" Callaway 2007-11-20 22:23:49 UTC

CVS done, builds away! Thanks for the review.