Bug 378331
| Summary: | Review Request: lrzip - Compression program optimised for large files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Warren Togami <wtogami> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-11-29 15:37:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Warren Togami
2007-11-12 17:25:58 UTC
Though mock build is successful and rpmlint reports no messages aginst SRPM and RPM but it does against debuginfo. Should we care those messages and try to solve them? I got rpmlint output on debuginfo package as lrzip-debuginfo.i386: W: spurious-executable-perm /usr/src/debug/lrzip-0.18/lzma/C/7zip/Compress/RangeCoder/RangeCoder.h lrzip-debuginfo.i386: E: wrong-script-end-of-line-encoding /usr/src/debug/lrzip-0.18/lzma/C/7zip/Compress/RangeCoder/RangeCoder.h ..... ..... many source files reported same messages like above for debuginfo package. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 285c995f6d861c4125f6164ab0ab2368 lrzip-0.18.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package lrzip-0.18-1.fc8 -> Requires: libbz2.so.1 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) liblzo2.so.2 libm.so.6 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH) + Not a GUI App. We really shouldn't care about the permissions in a debuginfo package. APPROVED. I am not understanding what goes wrong here. But I can see package in rawhide. I don't understand howcome package got entered without fedora-cvs+ I only forgot to set it. Package Change Request ====================== Package Name: lrzip Updated Fedora Owners: warren, spstarr Correct FAS name Package Change Request ====================== Package Name: lrzip Updated Fedora Owners: wtogami, spstarr cvs done. |