Bug 392291
| Summary: | Review Request: perl-Test-MinimumVersion - Check whether your code requires a newer perl | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralf Corsepius <rc040203> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 8 | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.007-1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-11-29 04:08:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 392261, 392271 | ||
| Bug Blocks: | 392301, 392311, 392321, 392331, 392341, 398451 | ||
|
Description
Ralf Corsepius
2007-11-20 13:41:52 UTC
* source files match upstream: 322c87ef495575005995001f8b69e44c2b252c4318cbc35b554d7dee671d067e Test-MinimumVersion-0.007.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Test::MinimumVersion) = 0.007 perl(Test::MinimumVersion::YAMLTiny) = 1.12 perl-Test-MinimumVersion = 0.007-1.fc9 = perl >= 0:5.005 perl(:MODULE_COMPAT_5.8.8) perl(Exporter) perl(File::Find::Rule) perl(File::Find::Rule::Perl) perl(Perl::MinimumVersion) perl(Test::Builder) perl(strict) perl(vars) perl(version) * %check is present and all tests pass: All tests successful. Files=2, Tests=2, 0 wallclock secs ( 0.19 cusr + 0.04 csys = 0.23 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED New Package CVS Request ======================= Package Name: perl-Test-Perl-MinimumVersion Short Description: Check whether your code requires a newer perl than you think. Owners: corsepiu Branches: F-8 F-7 InitialCC: fedora-perl-devel-list Cvsextras Commits: yes CVS done. Seems as if the cvs went wrong. I can't import the package: # common/cvs-import.sh perl-Test-MinimumVersion-0.007-1.fc8.src.rpm Checking out module: 'perl-Test-MinimumVersion' Enter passphrase for key '/users/packman/.ssh/id_dsa': cvs server: cannot find module `perl-Test-MinimumVersion' - ignored cvs [checkout aborted]: cannot expand modules ERROR: "perl-Test-MinimumVersion" module does not exist in cvs. New Package CVS Request ======================= Package Name: perl-Test-Perl-MinimumVersion Short Description: Check whether your code requires a newer perl than you think. Owners: corsepiu Branches: F-8 F-7 InitialCC: fedora-perl-devel-list Cvsextras Commits: yes perl-Test-Perl-MinimumVersion is definitely there; I just checked it out. However, in comment 4, you tried to check out perl-Test-MinimumVersion (no "-Perl"). So which is the proper name for this package? You've made the CVS request for perl-Test-Perl-MinimumVersion twice. (In reply to comment #6) > So which is the proper name for this package? You've made the CVS request for > perl-Test-Perl-MinimumVersion twice. perl-Test-MinimumVersion would have been correct. Cut'n'pasto stem from Fedora's infrastructure's lack of usability :( New Package CVS Request ======================= Package Name: perl-Test-MinimumVersion Short Description: Check whether your code requires a newer perl than you think. Owners: corsepiu Branches: F-8 F-7 InitialCC: fedora-perl-devel-list Cvsextras Commits: yes cvs done. Packages pushed for FC-7, FC-8 and rawhide |