Bug 398111
| Summary: | Review Request: xfce4-time-out-plugin - Xfce panel plugin for taking breaks from the computer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christoph Wickert <christoph.wickert> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, kevin, nonamedotc, notting |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.1.1-1.fc8 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-03-16 19:29:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Christoph Wickert
2007-11-25 00:14:30 UTC
Files have moved to http://cwickert.fedorapeople.org/review/xfce4-time-out-plugin.spec http://cwickert.fedorapeople.org/review/xfce4-time-out-plugin-0.1.1-1.fc9.src.rpm I would be happy to review this... look for a full review in a bit. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: d2f5b157cf47c754d8dd007c73a4d1e6 xfce4-time-out-plugin-0.1.1.tar.bz2 d2f5b157cf47c754d8dd007c73a4d1e6 xfce4-time-out-plugin-0.1.1.tar.bz2.spec See below - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. I see: checking for IceConnectionNumber in -lICE... no In the build log. Should this BuildRequire: libICE-devel ? Or is this a cosmetic test thats not really needed here? That's the only (very minor) issue I find here... If you could check on that requirement before checking in that would be great. This package is APPROVED. Thanks for the review. (In reply to comment #3) > In the build log. Should this BuildRequire: libICE-devel ? > Or is this a cosmetic test thats not really needed here? I guess that's a relict from the panel plugin example code but I will check that before build. New Package CVS Request ======================= Package Name: xfce4-time-out-plugin Short Description: Xfce panel plugin for taking breaks from the computer Owners: cwickert Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes cvs done. xfce4-time-out-plugin-0.1.1-1.fc8 has been submitted as an update for Fedora 8 xfce4-time-out-plugin-0.1.1-1.fc7 has been submitted as an update for Fedora 7 xfce4-time-out-plugin-0.1.1-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. xfce4-time-out-plugin-0.1.1-1.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: xfce4-time-out-plugin New Branches: epel7 Owners: cwickert InitialCC: nonamedotc Git done (by process-git-requests). |